[vlc-commits] [Git][videolan/vlc][3.0.x] fetcher: don't download network metadata if the user doesn't want to

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
5cdb9b25 by Steve Lhomme at 2024-10-16T09:38:27+00:00
fetcher: don't download network metadata if the user doesn't want to

The option is defined as "Allow metadata network access". If it's false (default but query during the first run) that means the
user doesn't want to check metadata from the network.
So we should not start a network job when there's a possibility to do it.

This is a regression from ea88b8d68e252445bcc305fd7a3dd45ef3ce0126.
Before that we only used FETCHER_SCOPE_LOCAL if the option wasn't set.

(cherry picked from commit 1a85d6793948c88afe35692d8c17a82089a58f33)

- - - - -


1 changed file:

- src/playlist/fetcher.c


Changes:

=====================================
src/playlist/fetcher.c
=====================================
@@ -294,7 +294,7 @@ static void SearchLocal( playlist_fetcher_t* fetcher, struct fetcher_request* re
     if( SearchByScope( fetcher, req, FETCHER_SCOPE_LOCAL ) == VLC_SUCCESS )
         return; /* done */
 
-    if( var_InheritBool( fetcher->owner, "metadata-network-access" ) ||
+    if( var_InheritBool( fetcher->owner, "metadata-network-access" ) &&
         req->options & META_REQUEST_OPTION_SCOPE_NETWORK )
     {
         if( background_worker_Push( fetcher->network, req, NULL, 0 ) )



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5cdb9b25440ec1d295e76bc866227a6f91502d55

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/5cdb9b25440ec1d295e76bc866227a6f91502d55
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance