[vlc-commits] [Git][videolan/vlc][master] 3 commits: qt: do not scale CSD window margin by the application scale factor

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
1870db6e by Fatih Uzunoglu at 2024-10-27T18:22:56+00:00
qt: do not scale CSD window margin by the application scale factor

Since size in QML is not device independent, the scaling is already
applied.

- - - - -
2461790c by Fatih Uzunoglu at 2024-10-27T18:22:56+00:00
qt: do not scale CSD resize handle size by the application scale factor

Since size in QML is not device independent, the scaling is already
applied.

- - - - -
645df3a0 by Fatih Uzunoglu at 2024-10-27T18:22:56+00:00
qt: increase CSD resize handle size from 5dp to 10dp

5dp is too small for accessibility, 10dp seems to be
a sweet spot.

- - - - -


2 changed files:

- modules/gui/qt/maininterface/mainctx.hpp
- modules/gui/qt/maininterface/qml/MainInterface.qml


Changes:

=====================================
modules/gui/qt/maininterface/mainctx.hpp
=====================================
@@ -211,7 +211,7 @@ public:
     inline bool isShowRemainingTime() const  { return m_showRemainingTime; }
     inline double getIntfScaleFactor() const { return m_intfScaleFactor; }
     inline double getIntfUserScaleFactor() const { return m_intfUserScaleFactor; }
-    inline int CSDBorderSize() const { return 5 * getIntfScaleFactor(); }
+    inline int CSDBorderSize() const { return 10; }
     inline double getMinIntfUserScaleFactor() const { return MIN_INTF_USER_SCALE_FACTOR; }
     inline double getMaxIntfUserScaleFactor() const { return MAX_INTF_USER_SCALE_FACTOR; }
     inline bool hasMediaLibrary() const { return b_hasMedialibrary; }


=====================================
modules/gui/qt/maininterface/qml/MainInterface.qml
=====================================
@@ -100,7 +100,7 @@ Item {
         Binding {
             target: MainCtx
             property: "windowExtendedMargin"
-            value: _extendedFrameVisible ? VLCStyle.dp(20, VLCStyle.scale) : 0
+            value: _extendedFrameVisible ? 20 : 0
         }
 
         Window.onWindowChanged: {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/1271d51e37c0bd00cd31023560716006fd5ede5c...645df3a0ef5688cdf0c7ccf80f46f0c13c39ce33

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/1271d51e37c0bd00cd31023560716006fd5ede5c...645df3a0ef5688cdf0c7ccf80f46f0c13c39ce33
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance