[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: use proper condition for applying opacity to player control bar background

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
7c3ebc76 by Fatih Uzunoglu at 2024-10-28T06:00:04+00:00
qml: use proper condition for applying opacity to player control bar background

The condition is explained as "Fullscreen controller opacity between 0.1 and 1",
and it is only relevant when there is video in the background (controls overlay
the video).

- - - - -
ed055b9d by Fatih Uzunoglu at 2024-10-28T06:00:04+00:00
qml: use translucent background in player control bar only when applicable

It can use translucent background in these cases:
- Overlaying the video.
- Window has backdrop blur effect.
- There is artwork cover effect in the background.

Currently, translucency is applied without checking if the window has
backdrop blur effect.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/Player.qml


Changes:

=====================================
modules/gui/qt/player/qml/Player.qml
=====================================
@@ -584,8 +584,8 @@ FocusScope {
 
             anchors.fill: parent
 
-            opacity: (MainCtx.intfMainWindow.visibility === Window.FullScreen) ? MainCtx.pinOpacity
-                                                                               : 1.0
+            opacity: (MainCtx.intfMainWindow.visibility === Window.FullScreen && MainCtx.hasEmbededVideo) ? MainCtx.pinOpacity
+                                                                                                          : 1.0
 
             tintColor: windowTheme.bg.primary
 
@@ -843,7 +843,8 @@ FocusScope {
 
             visible: !MainCtx.hasEmbededVideo || MainCtx.pinVideoControls
 
-            opacity: MainCtx.pinVideoControls ? MainCtx.pinOpacity : 0.7
+            opacity: (Window.visibility === Window.FullScreen && MainCtx.hasEmbededVideo) ? MainCtx.pinOpacity
+                                                                                          : ((AcrylicController.enabled || !MainCtx.hasEmbededVideo) ? 0.7 : 1.0)
 
             color: windowTheme.bg.primary
         }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c96d243056249804938bb35f7bbc5731e97de449...ed055b9dfb5f2dfee3ad73ee7dca2825ba780d62

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c96d243056249804938bb35f7bbc5731e97de449...ed055b9dfb5f2dfee3ad73ee7dca2825ba780d62
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance