[vlc-commits] [Git][videolan/vlc][master] qml: do not push player view repeatedly in artwork info button

Felix Paul Kühne (@fkuehne) gitlab at videolan.org
Sat Sep 7 18:54:39 UTC 2024



Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
149faea3 by Fatih Uzunoglu at 2024-09-07T18:42:12+00:00
qml: do not push player view repeatedly in artwork info button

If player is visible, it should not push player again.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/controlbarcontrols/ArtworkInfoWidget.qml


Changes:

=====================================
modules/gui/qt/player/qml/controlbarcontrols/ArtworkInfoWidget.qml
=====================================
@@ -79,14 +79,22 @@ AbstractButton {
 
         if (KeyHelper.matchOk(event)) {
             event.accepted = true
-
-            History.push(["player"])
+            clicked()
         }
     }
 
     // Events
 
-    onClicked: History.push(["player"])
+    onClicked: {
+        if (History.match(History.viewPath, ["player"])) {
+            if (MainCtx.mediaLibraryAvailable)
+                History.push(["mc", "video"])
+            else
+                History.push(["mc", "home"])
+        } else {
+            History.push(["player"])
+        }
+    }
 
     // Children
 
@@ -117,7 +125,7 @@ AbstractButton {
 
             grabPermissions: TapHandler.CanTakeOverFromHandlersOfDifferentType | TapHandler.ApprovesTakeOverByAnything
 
-            onTapped: History.push(["player"])
+            onTapped: root.clicked()
         }
 
         DragHandler {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/149faea34d4371a44dbbd4779c726f26690a42c5

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/149faea34d4371a44dbbd4779c726f26690a42c5
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list