[vlc-commits] [Git][videolan/vlc][master] 23 commits: macosx: Add starter VLCLibraryAbstractSegmentViewController

Thu Sep 12 05:00:49 UTC 2024

Felix Paul Kühne pushed to branch master at VideoLAN / VLC

Commits:
ec0a766b by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Add starter VLCLibraryAbstractSegmentViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4d402730 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Set up basic library window related properties in abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
035eac8d by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Subclass abstract segment view controller in groups view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
afcc7bd9 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Adapt audio view controller to subclass abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d003c556 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Adapt home view controller to abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
369cbef9 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Adapt media source view controller to abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
dbecb8df by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Adapt playlist view controller to abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
472f7a25 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Adapt library video view controller to subclass abstract segment view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
55d3c507 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Consolidate all segment view controller properties into one in library window, do not retain

Improve system usage by not keeping around segment view controllers and all of their dependents when they are not being used

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6f1847d4 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Remove unused segmentedTitleControl property in home view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6f81a739 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Remove unused delegate property in home view base carousel container view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
b6b5c9ae by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Use retained media source library view controller on segment property in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
b0a7ca40 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Keep weak reference to parent scroll view in vlc sub scroll view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
587c1823 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark IBOutlet type properties as weak

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
df502bcc by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark properties holding VLCLibraryWindow as weak

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
44516af4 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark properties holding VLCLibraryModel as weak

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ea1bcf40 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark properties holding views in library data sources as weak

These views are always held by parent view controllers

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
badf2579 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark properties holding references to library window-owned views in library segment view controllers as weak

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6909e27a by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Expose internalScrollView as an IBOutlet in collection view supplementary view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5f215d12 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Mark parent scroll view in collection view supplementary detail view property as weak

This is held by a parent view in use

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8e18ef46 by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Separate setup of table views, videos data source and shows data source

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
fe14016d by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Do not keep around data sources that are not being used in video view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
635ae6fc by Claudio Cambra at 2024-09-12T04:38:00+00:00
macosx: Fix crash due to visual constraint variable error in video view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -

30 changed files:

- extras/package/macosx/VLC.xcodeproj/project.pbxproj
- modules/gui/macosx/Makefile.am
- modules/gui/macosx/library/VLCLibraryAbstractGroupingDataSource.h
- + modules/gui/macosx/library/VLCLibraryAbstractSegmentViewController.h
- + modules/gui/macosx/library/VLCLibraryAbstractSegmentViewController.m
- modules/gui/macosx/library/VLCLibraryCollectionViewItem.h
- modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.h
- modules/gui/macosx/library/VLCLibraryHeroView.h
- modules/gui/macosx/library/VLCLibraryMasterDetailViewTableViewDataSource.h
- modules/gui/macosx/library/VLCLibraryNavigationStack.h
- modules/gui/macosx/library/VLCLibraryTableCellView.h
- modules/gui/macosx/library/VLCLibraryWindow.h
- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/library/VLCLibraryWindowNavigationSidebarViewController.h
- modules/gui/macosx/library/VLCLibraryWindowPlaylistSidebarViewController.h
- modules/gui/macosx/library/audio-library/VLCLibraryAlbumTableCellView.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioDataSource.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.m
- modules/gui/macosx/library/audio-library/VLCLibrarySongTableCellView.h
- modules/gui/macosx/library/groups-library/VLCLibraryGroupsDataSource.h
- modules/gui/macosx/library/groups-library/VLCLibraryGroupsViewController.h
- modules/gui/macosx/library/groups-library/VLCLibraryGroupsViewController.m
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewBaseCarouselContainerView.h
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewController.h
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewController.m
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewStackViewController.h
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewVideoContainerViewDataSource.h
- modules/gui/macosx/library/media-source/VLCLibraryMediaSourceViewController.h
- modules/gui/macosx/library/media-source/VLCLibraryMediaSourceViewController.m

The diff was not included because it is too large.

View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/d4d879a8ae340efaea47d4abf12597e81d652167...635ae6fc2d4e4f678307b385b80db12f7b28f334

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/d4d879a8ae340efaea47d4abf12597e81d652167...635ae6fc2d4e4f678307b385b80db12f7b28f334
You're receiving this email because of your account on code.videolan.org.

VideoLAN code repository instance