[vlc-commits] [Git][videolan/vlc][master] 8 commits: qt: fix race condition on the Qml playlist instance initialisation

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
4db4c7a9 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: fix race condition on the Qml playlist instance initialisation

when loading the interface we wait for the onPlaylistInitialized signal but this
signal may be emitted before the interface is loaded, now we wait on a boolean
state instead

- - - - -
92f71ae8 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: remove dependency on p_intf from ControlbarProfileModel

- - - - -
255f1c4b by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: move isCurrentItemSynced to private API of PlayerController

- - - - -
7185cd64 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: move art fetch callbacks to the cpp side

- - - - -
ffb7d092 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: remove unecessary includes from MainCtx

- - - - -
1b2afcd1 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: inject playlist controller as a depency in MediaLib

- - - - -
0cd4f244 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: don't store mlcustomcover instance in the medialibrary

we don't need to store the image provider inside the medialibray as it's only
useful to the QMLEngine. We only needed it fot crafting URL, but this can be
done with a stateless function.

- - - - -
3855b461 by Pierre Lamot at 2024-09-13T13:17:01+00:00
qt: make MLThreadRunner a disctinctive object from MediaLib

this allows to handle the part that requires the deleteLater within the MediaLib
class, this will allow us to handle the lifecycle of MediaLib like the other singletons

- - - - -


30 changed files:

- modules/gui/qt/dialogs/firstrun/firstrunwizard.cpp
- modules/gui/qt/dialogs/systray/systray.cpp
- modules/gui/qt/dialogs/toolbar/controlbar_profile_model.cpp
- modules/gui/qt/dialogs/toolbar/controlbar_profile_model.hpp
- modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.cpp
- modules/gui/qt/maininterface/compositor_win7.hpp
- modules/gui/qt/maininterface/compositor_x11.cpp
- modules/gui/qt/maininterface/interface_window_handler.cpp
- modules/gui/qt/maininterface/mainctx.cpp
- modules/gui/qt/maininterface/mainctx.hpp
- modules/gui/qt/maininterface/mainctx_win32.cpp
- modules/gui/qt/maininterface/mainctx_win32.hpp
- modules/gui/qt/maininterface/mainui.cpp
- modules/gui/qt/maininterface/qml/MainInterface.qml
- modules/gui/qt/medialibrary/medialib.cpp
- modules/gui/qt/medialibrary/medialib.hpp
- modules/gui/qt/medialibrary/mlcustomcover.cpp
- modules/gui/qt/medialibrary/mlcustomcover.hpp
- modules/gui/qt/medialibrary/mlfolder.cpp
- modules/gui/qt/medialibrary/mlfoldersmodel.cpp
- modules/gui/qt/medialibrary/mlgenremodel.cpp
- modules/gui/qt/medialibrary/mlplaylistlistmodel.cpp
- modules/gui/qt/medialibrary/mlvideofoldersmodel.cpp
- modules/gui/qt/medialibrary/mlvideogroupsmodel.cpp
- modules/gui/qt/menus/menus.cpp
- modules/gui/qt/menus/qml_menu_wrapper.cpp
- modules/gui/qt/menus/qml_menu_wrapper.hpp
- modules/gui/qt/network/networkmediamodel.cpp
- modules/gui/qt/player/player_controller.cpp
- modules/gui/qt/player/player_controller.hpp


The diff was not included because it is too large.


View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/592eab2abcb1895f288f7d1b1c44f1a211a74cdd...3855b4610654aa4b926061e0e9d66f64566ca6f4

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/592eab2abcb1895f288f7d1b1c44f1a211a74cdd...3855b4610654aa4b926061e0e9d66f64566ca6f4
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance