[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: fix artist list background exceeding view boundaries

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
53fe909f by Fatih Uzunoglu at 2024-09-14T10:25:37+00:00
qml: fix artist list background exceeding view boundaries

It is not clear why this item was placed in the hierarchy.
Ideally, the view should be a pane and the `AcrylicBackground`
should be its background item. But for now, placing it
as its child with `z: -1` and anchoring to the parent (the
view) seems to suffice.

- - - - -
eaa2a651 by Fatih Uzunoglu at 2024-09-14T10:25:37+00:00
qml: provide the effective background color to the effect in TracksListPage

If "transparent" color is provided, fading edge can not do sub-pixel font
rendering. Translucent colors should be used only when absolutely necessary,
such as when window background needs to be shown for the backdrop blur
filter.

In this case, it already has a solid background due to `stackViewParent` in
`MainDisplay.qml`, that color should have been used instead.

- - - - -


2 changed files:

- modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
- modules/gui/qt/player/qml/TracksListPage.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
=====================================
@@ -119,18 +119,6 @@ FocusScope {
         model: artistModel
     }
 
-    Widgets.AcrylicBackground {
-      id: artistListBackground
-
-      visible: artistList.visible
-      width: parent.width
-      height: parent.height + artistList.displayMarginEnd
-
-      tintColor: artistList.colorContext.bg.secondary
-
-      focus: false
-    }
-
     RowLayout {
         anchors.fill: parent
         anchors.leftMargin: root.leftPadding
@@ -160,6 +148,17 @@ FocusScope {
             fadingEdge.backgroundColor: artistListBackground.usingAcrylic ? "transparent"
                                                                           : artistListBackground.alternativeColor
 
+            Widgets.AcrylicBackground {
+                id: artistListBackground
+
+                z: -1
+
+                anchors.fill: parent
+                anchors.bottomMargin: -artistList.displayMarginEnd
+
+                tintColor: artistList.colorContext.bg.secondary
+            }
+
             // To get blur effect while scrolling in mainview
             displayMarginEnd: g_mainDisplay.displayMargin
 


=====================================
modules/gui/qt/player/qml/TracksListPage.qml
=====================================
@@ -36,7 +36,7 @@ RowLayout {
     readonly property ColorContext colorContext: ColorContext {
         id: theme
 
-        colorSet: ColorContext.Window // copied from TracksPage, maybe use Pane?
+        colorSet: ColorContext.View
     }
 
     //FIXME make TrackMenuController a proper type (see TrackMenu)
@@ -206,7 +206,7 @@ RowLayout {
                     focus: true
                     clip: true
 
-                    fadingEdge.backgroundColor: "transparent"
+                    fadingEdge.backgroundColor: theme.bg.primary
 
                     Accessible.role: Accessible.List
                     Accessible.name: qsTr("Track list")



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c19d9d6940261170734b80df06a92881815c899c...eaa2a6510b9bbf29703e512c90e3572574fd9430

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c19d9d6940261170734b80df06a92881815c899c...eaa2a6510b9bbf29703e512c90e3572574fd9430
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance