[vlc-commits] [Git][videolan/vlc][master] audiotrack: remove unused writeBufferV21

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
b5e27edc by Thomas Guillem at 2024-09-17T09:25:43+00:00
audiotrack: remove unused writeBufferV21

This could lead to the "write" method being NULL and used for API 22 and
21.

Fixes regression from ccd3eaae3f34359fa58f0ab6527e5f12e63e2ffb

- - - - -


1 changed file:

- modules/audio_output/android/audiotrack.c


Changes:

=====================================
modules/audio_output/android/audiotrack.c
=====================================
@@ -148,7 +148,6 @@ static struct
         jmethodID write;
         jmethodID writeV23;
         jmethodID writeShortV23;
-        jmethodID writeBufferV21;
         jmethodID writeFloat;
         jmethodID getAudioSessionId;
         jmethodID getBufferSizeInFrames;
@@ -291,10 +290,8 @@ AudioTrack_InitJNI( vlc_object_t *p_aout)
 
     GET_ID( GetMethodID, AudioTrack.writeV23, "write", "([BIII)I", false );
     GET_ID( GetMethodID, AudioTrack.writeShortV23, "write", "([SIII)I", false );
-    if( !jfields.AudioTrack.writeV23 )
-        GET_ID( GetMethodID, AudioTrack.writeBufferV21, "write", "(Ljava/nio/ByteBuffer;II)I", false );
 
-    if( jfields.AudioTrack.writeV23 || jfields.AudioTrack.writeBufferV21 )
+    if( jfields.AudioTrack.writeV23 )
     {
         GET_CONST_INT( AudioTrack.WRITE_NON_BLOCKING, "WRITE_NON_BLOCKING", true );
 #ifdef AUDIOTRACK_USE_FLOAT



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b5e27edcd186f7d64f3013e1807de974d33de016

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b5e27edcd186f7d64f3013e1807de974d33de016
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance