[vlc-commits] [Git][videolan/vlc][master] avsb: fix stop not stopping the renderer

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
ef1064d4 by Thomas Guillem at 2024-09-21T11:25:56+00:00
avsb: fix stop not stopping the renderer

In the unlikely case where no audio were processed by the renderer
thread (yet).

This resulted on various crashes from the renderer thread when spamming
audio device change from the OS.

- - - - -


1 changed file:

- modules/audio_output/apple/avsamplebuffer.m


Changes:

=====================================
modules/audio_output/apple/avsamplebuffer.m
=====================================
@@ -408,7 +408,7 @@ customBlock_Free(void *refcon, void *doomedMemoryBlock, size_t sizeInBytes)
 {
     NSNotificationCenter *notifCenter = [NSNotificationCenter defaultCenter];
 
-    if (_ptsSamples > 0)
+    if (_ptsSamples >= 0)
         [self stopSyncRenderer];
 
     [_sync removeRenderer:_renderer atTime:kCMTimeInvalid completionHandler:nil];



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ef1064d45d1d8e937a255c9442cc541d8fc4f6ba

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ef1064d45d1d8e937a255c9442cc541d8fc4f6ba
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance