[vlc-commits] [Git][videolan/vlc][master] 3 commits: macosx: Use same measurements for collection view and table view insets in media source view

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
a379ae1c by Claudio Cambra at 2024-09-23T04:40:59+00:00
macosx: Use same measurements for collection view and table view insets in media source view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5e0d746a by Claudio Cambra at 2024-09-23T04:40:59+00:00
macosx: Do not add spacing with path control/top parent view in media source views

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f2993dd3 by Claudio Cambra at 2024-09-23T04:40:59+00:00
macosx: Fix scroller insets for media source base data source views

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/media-source/VLCMediaSourceBaseDataSource.m


Changes:

=====================================
modules/gui/macosx/library/media-source/VLCMediaSourceBaseDataSource.m
=====================================
@@ -464,20 +464,19 @@ referenceSizeForHeaderInSection:(NSInteger)section
     _pathControlVisualEffectView.hidden = !visible;
 
     const CGFloat pathControlVisualEffectViewHeight = _pathControlVisualEffectView.frame.size.height;
-    const CGFloat scrollViewsTopSpace = visible ? pathControlVisualEffectViewHeight + VLCLibraryUIUnits.mediumSpacing : VLCLibraryUIUnits.mediumSpacing;
+    const CGFloat scrollViewsTopSpace = visible ? pathControlVisualEffectViewHeight : 0;
 
-    NSEdgeInsets collectionViewScrollViewInsets = VLCLibraryUIUnits.libraryViewScrollViewContentInsets;
-    collectionViewScrollViewInsets.top += scrollViewsTopSpace;
-    NSEdgeInsets collectionViewScrollerInsets = VLCLibraryUIUnits.libraryViewScrollViewScrollerInsets;
-    collectionViewScrollerInsets.top += scrollViewsTopSpace;
+    NSEdgeInsets scrollViewInsets = VLCLibraryUIUnits.libraryViewScrollViewContentInsets;
+    scrollViewInsets.top += scrollViewsTopSpace;
+    const NSEdgeInsets scrollerInsets = VLCLibraryUIUnits.libraryViewScrollViewScrollerInsets;
 
     _collectionViewScrollView.automaticallyAdjustsContentInsets = NO;
-    _collectionViewScrollView.contentInsets = collectionViewScrollViewInsets;
-    _collectionViewScrollView.scrollerInsets = collectionViewScrollerInsets;
+    _collectionViewScrollView.contentInsets = scrollViewInsets;
+    _collectionViewScrollView.scrollerInsets = scrollerInsets;
 
-    NSEdgeInsets tableViewScrollViewInsets = VLCLibraryUIUnits.libraryViewScrollViewContentInsets;
-    tableViewScrollViewInsets.top = scrollViewsTopSpace;
-    _tableViewScrollView.contentInsets = tableViewScrollViewInsets;
+    _tableViewScrollView.automaticallyAdjustsContentInsets = NO;
+    _tableViewScrollView.contentInsets = scrollViewInsets;
+    _tableViewScrollView.scrollerInsets = scrollerInsets;
 }
 
 - (void)returnHome



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e5d0b63c5fd220e0f15ac14f58971d2769af6cf6...f2993dd38eeda96bbdef84e93cc415d483886e84

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e5d0b63c5fd220e0f15ac14f58971d2769af6cf6...f2993dd38eeda96bbdef84e93cc415d483886e84
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance