[vlc-commits] [Git][videolan/vlc][master] qml: don't put new indicator as child of GridItem

Steve Lhomme (@robUx4) gitlab at videolan.org
Sat Sep 28 06:04:58 UTC 2024



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
e5fc9cc4 by Prince Gupta at 2024-09-28T05:51:21+00:00
qml: don't put new indicator as child of GridItem

fixes new indicator not visible anymore

fix regression from cbc63a0a55f
since the commit, content item is raised you can't put
element there anymore

- - - - -


1 changed file:

- modules/gui/qt/medialibrary/qml/VideoGridItem.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/VideoGridItem.qml
=====================================
@@ -27,7 +27,7 @@ import VLC.Style
 Widgets.GridItem {
     id: root
 
-    property alias showNewIndicator: image.visible
+    property bool showNewIndicator: false
     
     property var labels
 
@@ -50,6 +50,20 @@ Widgets.GridItem {
         width: root.pictureWidth
         height: root.pictureHeight
 
+        Widgets.ScaledImage {
+            id: image
+
+            anchors.right: parent.right
+            anchors.top: parent.top
+
+            width: VLCStyle.gridItem_newIndicator
+            height: width
+
+            visible: root.showNewIndicator
+
+            source: VLCStyle.newIndicator
+        }
+
         Widgets.VideoQualityLabels {
             anchors {
                 top: parent.top
@@ -79,18 +93,4 @@ Widgets.GridItem {
     }
 
     onPlayClicked: root.play()
-
-    Widgets.ScaledImage {
-        id: image
-
-        anchors.right: parent.right
-        anchors.top: parent.top
-
-        width: VLCStyle.gridItem_newIndicator
-        height: width
-
-        visible: false
-
-        source: VLCStyle.newIndicator
-    }
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e5fc9cc4be87e0f8c7e06e1cedd7e061a390c6ee

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e5fc9cc4be87e0f8c7e06e1cedd7e061a390c6ee
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list