[vlc-commits] [Git][videolan/vlc][master] win32/manifest: use the Segment Heap allocator on newer Windows

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0ecbdeb0 by Steve Lhomme at 2024-09-30T12:18:32+00:00
win32/manifest: use the Segment Heap allocator on newer Windows

It's supposed to be a better allocator than the default/legacy one [1]:

The value SegmentHeap indicates that segment heap will be used. Segment heap is a modern heap implementation that will generally reduce your overall memory usage. This element is supported in Windows 10, version 2004 (build 19041) and later.

On my usual test file (hardware decoding, dummy UI) I get from 266.1 Mo of
memory usage to 264.4 Mo (-0.6%). The results are consistent between runs.

[1] https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests#heaptype

- - - - -


1 changed file:

- extras/package/win32/vlc.exe.manifest


Changes:

=====================================
extras/package/win32/vlc.exe.manifest
=====================================
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
     <assemblyIdentity
         version="1.0.0.0"
         processorArchitecture="*"
@@ -7,7 +7,7 @@
         type="win32"
     />
     <description>see https://www.videolan.org/</description>
-     <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
+    <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
         <security>
             <requestedPrivileges>
                 <requestedExecutionLevel level="asInvoker" />
@@ -36,4 +36,9 @@
             <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
         </application>
     </compatibility>
+    <asmv3:application>
+        <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2020/WindowsSettings">
+            <heapType>SegmentHeap</heapType>
+        </asmv3:windowsSettings>
+    </asmv3:application>
 </assembly>



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0ecbdeb0dd18bc5b15030fe1503245462514d63c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0ecbdeb0dd18bc5b15030fe1503245462514d63c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance