[vlc-commits] [Git][videolan/vlc][master] qml: cut too long empty indicator texts in media library views

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
336d457c by Fatih Uzunoglu at 2025-04-01T06:16:23+00:00
qml: cut too long empty indicator texts in media library views

It is planned to disable word wrap in `EmptyLabel`,
in an attempt to have sensible implicit size. This
allows us to use minimum width approach instead in
the main view.

There is little use for being responsive (via word
wrap) in the empty indicator. Usually views should
have minimum size which is at least the empty
indicator size (similar to the playlist pane). Word
wrap does not look good, the words can stack up and
down, making a column of many words.

Instead, I propose cutting the text, so that we
can have sensible minimum size (width). Currently
the window already has reasonable minimum width, and
there is also `isScreenSmall` which makes the playlist
pane be placed on top of the main view (which makes
the main view have as much width as the window has).

- - - - -


6 changed files:

- modules/gui/qt/medialibrary/qml/MusicAlbums.qml
- modules/gui/qt/medialibrary/qml/MusicAllArtists.qml
- modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
- modules/gui/qt/medialibrary/qml/MusicGenres.qml
- modules/gui/qt/medialibrary/qml/MusicTracksDisplay.qml
- modules/gui/qt/medialibrary/qml/VideoAll.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/MusicAlbums.qml
=====================================
@@ -279,7 +279,7 @@ MainViewLoader {
         id: emptyLabelComponent
 
         Widgets.EmptyLabelButton {
-            text: qsTr("No albums found\nPlease try adding sources, by going to the Browse tab")
+            text: qsTr("No albums found\nPlease try adding sources")
             Navigation.parentItem: root
             cover: VLCStyle.noArtAlbumCover
         }


=====================================
modules/gui/qt/medialibrary/qml/MusicAllArtists.qml
=====================================
@@ -238,7 +238,7 @@ MainViewLoader {
         id: emptyLabelComponent
 
         Widgets.EmptyLabelButton {
-            text: qsTr("No artists found\nPlease try adding sources, by going to the Browse tab")
+            text: qsTr("No artists found\nPlease try adding sources")
             Navigation.parentItem: root
             cover: VLCStyle.noArtArtistCover
         }


=====================================
modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
=====================================
@@ -368,7 +368,7 @@ FocusScope {
 
         visible: !artistModel.loading && (artistModel.count <= 0)
         focus: visible
-        text: qsTr("No artists found\nPlease try adding sources, by going to the Browse tab")
+        text: qsTr("No artists found\nPlease try adding sources")
         Navigation.parentItem: root
     }
 }


=====================================
modules/gui/qt/medialibrary/qml/MusicGenres.qml
=====================================
@@ -293,7 +293,7 @@ MainViewLoader {
         id: emptyLabelComponent
 
         Widgets.EmptyLabelButton {
-            text: qsTr("No genres found\nPlease try adding sources, by going to the Browse tab")
+            text: qsTr("No genres found\nPlease try adding sources")
             Navigation.parentItem: root
             cover: VLCStyle.noArtAlbumCover
         }


=====================================
modules/gui/qt/medialibrary/qml/MusicTracksDisplay.qml
=====================================
@@ -88,7 +88,7 @@ FocusScope {
         anchors.fill: parent
         visible: !tracklistdisplay_id.model.loading && (tracklistdisplay_id.model.count <= 0)
         focus: visible
-        text: qsTr("No tracks found\nPlease try adding sources, by going to the Browse tab")
+        text: qsTr("No tracks found\nPlease try adding sources")
         Navigation.parentItem: root
         cover: VLCStyle.noArtAlbumCover
     }


=====================================
modules/gui/qt/medialibrary/qml/VideoAll.qml
=====================================
@@ -229,7 +229,7 @@ MainViewLoader {
 
             focus: true
 
-            text: qsTr("No video found\nPlease try adding sources, by going to the Browse tab")
+            text: qsTr("No video found\nPlease try adding sources")
 
             cover: VLCStyle.noArtVideoCover
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/336d457c0e696dfd6f57ad499ea245bb82d6e721

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/336d457c0e696dfd6f57ad499ea245bb82d6e721
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance