[vlc-commits] [Git][videolan/vlc][master] qml: accept all devices in playback speed control wheel handler

Steve Lhomme (@robUx4) gitlab at videolan.org
Mon Apr 7 11:01:12 UTC 2025



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
95a8efe4 by Fatih Uzunoglu at 2025-04-07T10:38:38+00:00
qml: accept all devices in playback speed control wheel handler

By default `WheelHandler` only accepts mouse (unlike other handlers
where all devices are accepted by default), and it also does not
make use of synthesized mouse events. We can accept all devices
here, I don't see why we should limit the accepted devices here.

Currently on Wayland certain mouse types are not reported as
"mouse", this is a problem for the wheel functionality of the
playback speed control. Accepting all devices fixes this issue.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/controlbarcontrols/PlaybackSpeedButton.qml


Changes:

=====================================
modules/gui/qt/player/qml/controlbarcontrols/PlaybackSpeedButton.qml
=====================================
@@ -101,6 +101,8 @@ PopupIconToolButton {
         WheelHandler {
             orientation: Qt.Vertical | Qt.Horizontal
 
+            acceptedDevices: PointerDevice.AllDevices
+
             onWheel: (wheel) => {
                 if (!root.popup.contentItem || !root.popup.contentItem.slider) {
                     event.accepted = false



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/95a8efe43af7ac5ab6ba061f662ecd8acd45f3b6

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/95a8efe43af7ac5ab6ba061f662ecd8acd45f3b6
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list