[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: prevent loading the empty indicator during initialization in `MainViewLoader`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
9f1919a0 by Fatih Uzunoglu at 2025-04-19T15:11:56+00:00
qml: prevent loading the empty indicator during initialization in `MainViewLoader`

- - - - -
a1affc6e by Fatih Uzunoglu at 2025-04-19T15:11:56+00:00
qml: call loading changed handler on component completion in `MainViewLoader`

- - - - -


1 changed file:

- modules/gui/qt/maininterface/qml/MainViewLoader.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/MainViewLoader.qml
=====================================
@@ -138,6 +138,8 @@ Loader {
 
         // NOTE: This call is useful to avoid a binding loop on currentComponent.
         currentComponentChanged.connect(_updateView)
+
+        isLoadingChanged() // in case boolean default value is `true`, currently it is not
     }
 
     onModelChanged: resetFocus()
@@ -216,7 +218,9 @@ Loader {
 
         z: 1
 
-        active: !count && emptyLabel && !(_loadingItem && _loadingItem.visible)
+        // We can not depend on the existence of loading indicator here, unless we want this to be a delayed binding.
+        // Instead, use the condition where loading indicator is created (either shown, or pending to be shown):
+        active: (root.count === 0) && root.emptyLabel && (!root.isLoading || !root.loadingComponent)
 
         sourceComponent: emptyLabel
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/4ead38efafafb9afaeb2629a239e0682a0a8abbc...a1affc6e322c9f0462518b577ca7b71e6a6320c3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/4ead38efafafb9afaeb2629a239e0682a0a8abbc...a1affc6e322c9f0462518b577ca7b71e6a6320c3
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance