[vlc-commits] [Git][videolan/vlc][master] macosx: Prefer drawsBackground = NO to backgroundColor = NSColor.clearColor

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
efe1f2e7 by Claudio Cambra at 2025-08-20T10:34:00+00:00
macosx: Prefer drawsBackground = NO to backgroundColor = NSColor.clearColor

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


2 changed files:

- modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryElementView.m
- modules/gui/macosx/library/media-source/VLCLibraryMediaSourceViewController.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryElementView.m
=====================================
@@ -44,8 +44,7 @@ NSString *VLCLibrarySupplementaryElementViewIdentifier = @"VLCLibrarySupplementa
         self.selectable = NO;
         self.bordered = NO;
         self.usesSingleLineMode = NO;
-        self.drawsBackground = YES;
-        self.backgroundColor = [NSColor clearColor];
+        self.drawsBackground = NO;
         self.allowsDefaultTighteningForTruncation = YES;
         self.maximumNumberOfLines = 1;
         self.lineBreakMode = NSLineBreakByTruncatingTail;


=====================================
modules/gui/macosx/library/media-source/VLCLibraryMediaSourceViewController.m
=====================================
@@ -137,7 +137,7 @@
     self.browsePlaceholderLabel.font = NSFont.VLClibrarySectionHeaderFont;
     self.browsePlaceholderLabel.textColor = NSColor.secondaryLabelColor;
     self.browsePlaceholderLabel.alignment = NSTextAlignmentCenter;
-    self.browsePlaceholderLabel.backgroundColor = NSColor.clearColor;
+    self.browsePlaceholderLabel.drawsBackground = NO;
     [self.mediaSourceView addSubview:self.browsePlaceholderLabel];
     [self.mediaSourceView addConstraints:@[
         [self.browsePlaceholderLabel.centerXAnchor constraintEqualToAnchor:self.mediaSourceView.centerXAnchor],



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/efe1f2e7342d3cc480d4c7055cd0c4c5dc650d63

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/efe1f2e7342d3cc480d4c7055cd0c4c5dc650d63
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance