[vlc-commits] [Git][videolan/vlc][master] test: player: modules: fix data-race

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0d51bf04 by Thomas Guillem at 2025-12-01T06:50:26+00:00
test: player: modules: fix data-race

```
WARNING: ThreadSanitizer: data race (pid=1482710)
  Write of size 8 at 0x7ffc083eeec8 by thread T3:
    #0 vlc_vector_reallocdata_ ../../include/vlc_vector.h:181 (test_src_player_discontinuities+0x28ab) (BuildId: 4aa32e859ff1646a7434510b5302b07861d62271)
    #1 aout_Play ../../test/src/player/modules.c:36 (test_src_player_discontinuities+0x2a1e) (BuildId: 4aa32e859ff1646a7434510b5302b07861d62271)
    #2 vlc_aout_stream_Play ../../src/audio_output/dec.c:957 (libvlccore.so.9+0xaa396) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)
    #3 ModuleThread_PlayAudio ../../src/input/decoder.c:1523 (libvlccore.so.9+0x62512) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)
    #4 ModuleThread_QueueAudio ../../src/input/decoder.c:1554 (libvlccore.so.9+0x62735) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)
    #5 decoder_QueueAudio ../../include/vlc_codec.h:476 (libaraw_plugin.so+0x29c5) (BuildId: 1aad6e313df15de1f486a181f90e037a012de0fa)
    #6 DecodeBlock ../../modules/codec/araw.c:362 (libaraw_plugin.so+0x3449) (BuildId: 1aad6e313df15de1f486a181f90e037a012de0fa)
    #7 DecoderThread_DecodeBlock ../../src/input/decoder.c:1636 (libvlccore.so.9+0x608af) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)
    #8 DecoderThread_ProcessInput ../../src/input/decoder.c:1762 (libvlccore.so.9+0x60d91) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)
    #9 DecoderThread ../../src/input/decoder.c:1876 (libvlccore.so.9+0x61002) (BuildId: 13da3aaa6541ff90a630e0bc4c2f079a7b6d6061)

  Previous read of size 8 at 0x7ffc083eeec8 by main thread:
    #0 test_clock_discontinuities ../../test/src/player/discontinuities.c:27 (test_src_player_discontinuities+0x9ab0) (BuildId: 4aa32e859ff1646a7434510b5302b07861d62271)
    #1 main ../../test/src/player/discontinuities.c:44 (test_src_player_discontinuities+0x9eff) (BuildId: 4aa32e859ff1646a7434510b5302b07861d62271)
```

- - - - -


1 changed file:

- test/src/player/modules.c


Changes:

=====================================
test/src/player/modules.c
=====================================
@@ -33,7 +33,9 @@ static void aout_Play(audio_output_t *aout, block_t *block, vlc_tick_t date)
         sys->first_pts = block->i_pts;
 
         struct ctx *ctx = sys->ctx;
+        vlc_player_Lock(ctx->player);
         VEC_PUSH(on_aout_first_pts, sys->first_pts);
+        vlc_player_Unlock(ctx->player);
     }
 
     aout_TimingReport(aout, sys->first_play_date + sys->pos - VLC_TICK_0,



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0d51bf0445614f87c18674a68b3c8b0ab5fda2d3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0d51bf0445614f87c18674a68b3c8b0ab5fda2d3
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance