[vlc-commits] [Git][videolan/vlc][master] 2 commits: test: preparser: rename request names to avoid variable shadowing

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
67a5adb2 by Ayush Dey at 2025-12-05T06:45:49+01:00
test: preparser: rename request names to avoid variable shadowing

- - - - -
c08a9690 by Ayush Dey at 2025-12-05T06:45:49+01:00
test: preparser: release thumbnail request after cancel test case

- - - - -


1 changed file:

- test/src/preparser/thumbnail_to_files.c


Changes:

=====================================
test/src/preparser/thumbnail_to_files.c
=====================================
@@ -115,9 +115,10 @@ static void parser_on_ended(vlc_preparser_req *req, int status, void *userdata)
     vlc_preparser_req_Release(req);
 }
 
-static void on_ended(vlc_preparser_req *req, int status,
+static void on_ended(vlc_preparser_req *thumbnailer_req, int status,
                      const bool *result_array, size_t result_count, void *data)
 {
+    (void) thumbnailer_req;
     struct context *context = data;
     assert(status == VLC_SUCCESS);
     assert(context->test_count == result_count);
@@ -155,15 +156,14 @@ static void on_ended(vlc_preparser_req *req, int status,
                 free(option);
             }
 
-            vlc_preparser_req *req =
+            vlc_preparser_req *parser_req =
                 vlc_preparser_Push(context->preparser, thumb,
                                    VLC_PREPARSER_TYPE_PARSE,
                                    &parser_cbs, context);
-            assert(req != NULL);
+            assert(parser_req != NULL);
             input_item_Release(thumb);
         }
     }
-    vlc_preparser_req_Release(req);
 }
 
 static int get_formats(enum vlc_thumbnailer_format *out_format,
@@ -344,6 +344,7 @@ int main(int argc, const char *argv[])
 
     size_t count = vlc_preparser_Cancel(preparser, req);
     assert(count == 0); /* Should not be cancelled and already processed */
+    vlc_preparser_req_Release(req);
 
     for (size_t i = 0; i < test_count; ++i)
         if (fd_array[i] != -1)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/ce896f409fd7234a1d8150e6bad7969f8a267a0f...c08a9690dcd91808c182440e7aadfd01139e4253

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/ce896f409fd7234a1d8150e6bad7969f8a267a0f...c08a9690dcd91808c182440e7aadfd01139e4253
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance