[vlc-commits] [Git][videolan/vlc][master] macos: fix a notification method signature

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
98bf91e3 by Maxime Chapelet at 2025-02-08T05:33:55+00:00
macos: fix a notification method signature

The wrong method parameter type was used for the PIP activation
method.

These changes are fixing that.

The notification associated `VLCPlayerController` object is also
used directly in the method implementation instead of accessing it
through a global object.

- - - - -


1 changed file:

- modules/gui/macosx/windows/video/VLCMainVideoViewController.m


Changes:

=====================================
modules/gui/macosx/windows/video/VLCMainVideoViewController.m
=====================================
@@ -499,7 +499,7 @@
     return _voutViewController != nil;
 }
 
-- (void)pictureInPictureChanged:(VLCPlayerController *)playerController
+- (void)pictureInPictureChanged:(NSNotification *)notification
 {
     if (self.pipIsActive) {
         return;
@@ -511,8 +511,7 @@
 
     _voutViewController = [PIPVoutViewController new];
     _voutViewController.view = self.voutContainingView;
-    VLCPlayerController * const controller =
-        VLCMain.sharedInstance.playQueueController.playerController;
+    VLCPlayerController * const controller = notification.object;
     _pipViewController.playing = controller.playerState == VLC_PLAYER_STATE_PLAYING;
     
     VLCInputItem * const item = controller.currentMedia;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/98bf91e355152738c71d702ed1514fba590a60f9

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/98bf91e355152738c71d702ed1514fba590a60f9
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance