[vlc-commits] [Git][videolan/vlc][master] test: thumbnail: fix spurious fail

Steve Lhomme (@robUx4) gitlab at videolan.org
Thu Feb 13 07:52:54 UTC 2025



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0c793839 by Thomas Guillem at 2025-02-13T07:19:02+00:00
test: thumbnail: fix spurious fail

Fixes the following assert:
```
Assertion failed: (status == -EINTR), function thumbnailer_callback_cancel, file thumbnail.c, line 194.
FAIL test_src_preparser_thumbnail (exit status: 134)
```

By increasing the length of the mock used to test cancellation. It was
200us, so it was possible that the thumbnailer finished before we could
cancel it.

Note that can_control_pace is false and that there are no video tracks,
so the thumbnailer will take 20 secs to find a thumbnail (and fail),
giving us enough time to cancel it.

Fixes #29018

- - - - -


1 changed file:

- test/src/preparser/thumbnail.c


Changes:

=====================================
test/src/preparser/thumbnail.c
=====================================
@@ -210,7 +210,7 @@ static void test_cancel_thumbnail( libvlc_instance_t* p_vlc )
     const char* psz_mrl = "mock://video_track_count=0;audio_track_count=1;"
                           /* force timeout: parsing will take the same time as length */
                           "can_control_pace=false;"
-                          "length=200";
+                          "length=20000000";
     input_item_t* p_item = input_item_New( psz_mrl, "mock item" );
     assert( p_item != NULL );
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0c793839fc1579448273ff05f74d915c250e0777

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0c793839fc1579448273ff05f74d915c250e0777
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list