[vlc-commits] [Git][videolan/vlc][master] caf: don't keep extra data for an unknown codec

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
b3ec88d5 by Steve Lhomme at 2025-02-14T09:16:47+00:00
caf: don't keep extra data for an unknown codec

The codec ID is set in ReadDescChunk(). And according to the error before using it:

> The audio description chunk must be the first chunk

We should not be using codec data if we don't have the codec.
The file will eventually fail with this error, but we don't need to
copy bogus data before that.

Fixes #29012

- - - - -


1 changed file:

- modules/demux/caf.c


Changes:

=====================================
modules/demux/caf.c
=====================================
@@ -716,7 +716,7 @@ static int ReadKukiChunk( demux_t *p_demux, uint64_t i_size )
         int error = ProcessAACCookie( p_demux, p_peek, i_size );
         if( error ) return error;
     }
-    else
+    else if( p_sys->fmt.i_codec != 0 )
     {
         p_sys->fmt.i_extra = i_size;
         p_sys->fmt.p_extra = malloc( i_size );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b3ec88d53167d4a3383db43328f10abcc454cebe

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b3ec88d53167d4a3383db43328f10abcc454cebe
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance