[vlc-commits] [Git][videolan/vlc][3.0.x] win32: Prevent VLC from registering as the default player for MIDI files

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
7b58309a by Vikram Kangotra at 2025-01-10T07:32:43+00:00
win32: Prevent VLC from registering as the default player for MIDI files

This commit resolves an issue where the installation of VLC on Windows
unintentionally designated it as the default application for MIDI files.
Given that Windows supports MIDI playback natively through Windows Media
Player and that VLC requires a SoundFont for proper MIDI playback, this
change ensures that VLC does not disrupt the default MIDI file associations,
maintaining the expected user experience.

Fixes: #27464
(cherry picked from commit dd4f9152118af3667f3befa568f20ed6e4cf4fb3)

- - - - -


1 changed file:

- extras/package/win32/NSIS/helpers/extensions.nsh


Changes:

=====================================
extras/package/win32/NSIS/helpers/extensions.nsh
=====================================
@@ -152,7 +152,6 @@ FunctionEnd
   !insertmacro ${_action} Audio ".it"
   !insertmacro ${_action} Audio ".m4a"
   !insertmacro ${_action} Audio ".m4p"
-  !insertmacro ${_action} Audio ".mid"
   !insertmacro ${_action} Audio ".mka"
   !insertmacro ${_action} Audio ".mlp"
   !insertmacro ${_action} Audio ".mod"
@@ -263,6 +262,7 @@ FunctionEnd
 
 !macro MacroUnassociatedExtensions _action
   !insertmacro ${_action} Other ".iso"
+  !insertmacro ${_action} Audio ".mid"
   !insertmacro ${_action} Other ".zip"
   !insertmacro ${_action} Other ".rar"
 !macroend



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7b58309ae72af83d2053bd88f0529e7addaddc6f

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7b58309ae72af83d2053bd88f0529e7addaddc6f
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance