[vlc-commits] [Git][videolan/vlc][master] qt: remove the overzealous assert in `ModelRecoveryAgent` destructor

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
6fed97a3 by Fatih Uzunoglu at 2025-01-20T13:01:48+00:00
qt: remove the overzealous assert in `ModelRecoveryAgent` destructor

If the user resets the preferences, closing the application appears
to lead to assertion failure.

This should not be a concern, because assertions should not be made
in release builds and the if statement afterward already covers the
invariant.

- - - - -


1 changed file:

- modules/gui/qt/util/model_recovery_agent.hpp


Changes:

=====================================
modules/gui/qt/util/model_recovery_agent.hpp
=====================================
@@ -160,7 +160,7 @@ public:
         assert(m_settings);
 
         m_settings->sync();
-        assert(m_settings->contains(m_key));
+
         if (m_settings->value(m_key) == m_recoveryFileName)
         {
             m_settings->remove(m_key);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6fed97a363c0580bce3f4cb3d700e5fd3b43b2e2

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6fed97a363c0580bce3f4cb3d700e5fd3b43b2e2
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance