[vlc-commits] [Git][videolan/vlc][master] qt: fix window destroyed before the vout window in DComp compositor

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
fdb0a981 by Pierre Lamot at 2025-01-31T17:39:06+00:00
qt: fix window destroyed before the vout window in DComp compositor

- - - - -


1 changed file:

- modules/gui/qt/maininterface/compositor_dcomp.cpp


Changes:

=====================================
modules/gui/qt/maininterface/compositor_dcomp.cpp
=====================================
@@ -337,13 +337,20 @@ void CompositorDirectComposition::destroyMainInterface()
         msg_Err(m_intf, "video surface still active while destroying main interface");
 
     commonIntfDestroy();
+    m_quickView.reset();
 }
 
 void CompositorDirectComposition::unloadGUI()
 {
     m_acrylicSurface.reset();
     m_interfaceWindowHandler.reset();
-    m_quickView.reset();
+
+    //at this point we need to unload the QML content but the window still need to
+    //be valid as it may still be used by the vout window.
+    //we cant' just delete the qmlEngine as the QmlView as the root item is parented to the QmlView
+    //setSource() to nothing will effectively destroy the root item
+    m_quickView->setSource(QUrl());
+
     commonGUIDestroy();
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fdb0a9811090e5f16f18259529f38bc3bcb4e8fe

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fdb0a9811090e5f16f18259529f38bc3bcb4e8fe
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance