[vlc-commits] [Git][videolan/vlc][master] Revert "VLCSampleBufferDisplay: remove empty Display callback"

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
df581a1e by Steve Lhomme at 2025-07-20T05:47:47+00:00
Revert "VLCSampleBufferDisplay: remove empty Display callback"

This reverts commit 5c06e5439dc9756df97a5e722e7ec194eb15a879.

The core is sending pictures too fast in this mode.

Even the Android display mode which can use the display date has a display
callback forcing the core to wait between pictures.

- - - - -


1 changed file:

- modules/video_output/apple/VLCSampleBufferDisplay.m


Changes:

=====================================
modules/video_output/apple/VLCSampleBufferDisplay.m
=====================================
@@ -1042,6 +1042,11 @@ static void Prepare (vout_display_t *vd, picture_t *pic,
     RenderSubpicture(vd, subpicture);
 }
 
+static void Display(vout_display_t *vd, picture_t *pic)
+{
+    // kept as the core is not properly pacing the calls to Prepare without this callback
+}
+
 static int Control (vout_display_t *vd, int query)
 {
     VLCSampleBufferDisplay *sys;
@@ -1150,6 +1155,7 @@ static int Open (vout_display_t *vd,
         static const struct vlc_display_operations ops = {
             .close = Close,
             .prepare = Prepare,
+            .display = Display,
             .control = Control,
             .update_format = UpdateFormat,
         };



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/df581a1ed37ad82282331fa5a64bab59c4d6c4a0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/df581a1ed37ad82282331fa5a64bab59c4d6c4a0
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance