[vlc-commits] [Git][videolan/vlc][master] macosx: Prevent displaying of end-of-playback view when video track is...

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
6642ae5e by Claudio Cambra at 2025-06-04T17:40:39+00:00
macosx: Prevent displaying of end-of-playback view when video track is disabled but playback is ongoing

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCLibraryWindow.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryWindow.m
=====================================
@@ -413,7 +413,14 @@ static void addShadow(NSImageView *__unsafe_unretained imageView)
         VLCMediaLibraryMediaItem * const mediaItem = [VLCMediaLibraryMediaItem mediaItemForURL:currentMediaUrl];
         const BOOL decorativeViewVisible = mediaItem != nil && mediaItem.mediaType == VLC_ML_MEDIA_TYPE_AUDIO;
 
-        if (!decorativeViewVisible && [NSUserDefaults.standardUserDefaults boolForKey:VLCPlaybackEndViewEnabledKey]) {
+        // If the playback end view is enabled and the player is stopped, display playback end view.
+        // We want to still display the decorative view for audio items.
+        // In other cases, we need to check that the player itself is in a stopped state. Removal of
+        // the active video can be triggered by more than just end of playback (e.g. disabling the
+        // video track).
+        if (!decorativeViewVisible &&
+            [NSUserDefaults.standardUserDefaults boolForKey:VLCPlaybackEndViewEnabledKey] &&
+            self.playerController.playerState == VLC_PLAYER_STATE_STOPPED) {
             [self.videoViewController displayPlaybackEndView];
         } else if (!decorativeViewVisible) {
             [self disableVideoPlaybackAppearance];



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6642ae5ef4f0196db272109d36a748e9c634d4f0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6642ae5ef4f0196db272109d36a748e9c634d4f0
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance