[vlc-commits] [Git][videolan/vlc][master] 3 commits: qml: generalize unsetting the cursor in view delegates that inherit `AbstractButton`

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
97e8ed96 by Fatih Uzunoglu at 2025-06-07T16:19:00+00:00
qml: generalize unsetting the cursor in view delegates that inherit `AbstractButton`

The cursor is already unset in playlist list delegate, which inherits `AbstractButton`,
but we need this in more places because we started using the busy indicator in these
places as well.

- - - - -
50b84fcd by Fatih Uzunoglu at 2025-06-07T16:19:00+00:00
qml: unset the cursor in `MusicArtistDelegate`

- - - - -
0f69f7d4 by Fatih Uzunoglu at 2025-06-07T16:19:00+00:00
qml: unset the cursor in `ViewHeader`

- - - - -


4 changed files:

- modules/gui/qt/medialibrary/qml/MusicArtistDelegate.qml
- modules/gui/qt/medialibrary/qml/PlaylistMediaList.qml
- modules/gui/qt/widgets/qml/GridItem.qml
- modules/gui/qt/widgets/qml/ViewHeader.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/MusicArtistDelegate.qml
=====================================
@@ -69,6 +69,12 @@ T.ItemDelegate {
 
     Accessible.onPressAction: root.itemClicked()
 
+    Component.onCompleted: {
+        // Qt Quick AbstractButton sets a cursor for itself, unset it so that if the view has
+        // busy cursor, it is visible over the delegate:
+        MainCtx.unsetCursor(this)
+    }
+
     // Childs
 
     readonly property ColorContext colorContext: ColorContext {


=====================================
modules/gui/qt/medialibrary/qml/PlaylistMediaList.qml
=====================================
@@ -332,12 +332,6 @@ MainViewLoader {
                         })
                     }
                 }
-
-                Component.onCompleted: {
-                    // Qt Quick Button sets a cursor for itself, unset it so that if the view has
-                    // busy cursor, it is visible over the delegate:
-                    MainCtx.unsetCursor(this)
-                }
             }
 
             //-------------------------------------------------------------------------------------


=====================================
modules/gui/qt/widgets/qml/GridItem.qml
=====================================
@@ -21,7 +21,7 @@ import QtQuick.Templates as T
 import QtQuick.Layouts
 import QtQml.Models
 
-
+import VLC.MainInterface
 import VLC.Widgets as Widgets
 import VLC.Util
 import VLC.Style
@@ -92,6 +92,12 @@ T.ItemDelegate {
 
     Keys.onMenuPressed: root.contextMenuButtonClicked(picture, root.mapToGlobal(0,0))
 
+    Component.onCompleted: {
+        // Qt Quick AbstractButton sets a cursor for itself, unset it so that if the view has
+        // busy cursor, it is visible over the delegate:
+        MainCtx.unsetCursor(this)
+    }
+
     // States
 
     states: [


=====================================
modules/gui/qt/widgets/qml/ViewHeader.qml
=====================================
@@ -60,6 +60,12 @@ T.Pane {
 
     Navigation.navigable: button.visible
 
+    Component.onCompleted: {
+        // Qt Quick Pane sets a cursor for itself, unset it so that if the view has
+        // busy cursor, it is visible over the header:
+        MainCtx.unsetCursor(this)
+    }
+
     // Children
 
     readonly property ColorContext colorContext: ColorContext {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a8f2e4b2cd12f9f0f01792656a0b36dac5e781fd...0f69f7d4201b68bbb1ec09a4549e09b3335c9747

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a8f2e4b2cd12f9f0f01792656a0b36dac5e781fd...0f69f7d4201b68bbb1ec09a4549e09b3335c9747
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance