[vlc-commits] [Git][videolan/vlc][master] libtool_cargo: fix frameworks being emitted to dependencies

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
d8746c8c by Alexandre Janniaux at 2025-03-02T07:21:18+00:00
libtool_cargo: fix frameworks being emitted to dependencies

libtool doesn't handle frameworks as dependencies, and only support them
as linker argument (ie. -Wl,-framework arguments). Remove them from the
link to prevent the linkage failure. This also means that they must be
provided manually in the makefile afterwards...

- - - - -


1 changed file:

- modules/libtool_cargo.sh


Changes:

=====================================
modules/libtool_cargo.sh
=====================================
@@ -52,7 +52,11 @@ LT_CONVENIENCE=$2
 $CARGO_RUSTC_CMD --manifest-path="$MODULE_PROJECT_DIR/Cargo.toml" -- ${CFGS}
 
 # "Build" the project a second time and fetch the native-static-libs to link with
-NATIVE_STATIC_LIBS=$($CARGO_RUSTC_CMD --manifest-path="$MODULE_PROJECT_DIR/Cargo.toml" --quiet -- ${CFGS} --print native-static-libs 2>&1 | grep "native-static-libs" | sed "s/note: native-static-libs://" | sed "s/-lvlccore//")
+NATIVE_STATIC_LIBS=$($CARGO_RUSTC_CMD --manifest-path="$MODULE_PROJECT_DIR/Cargo.toml" --quiet -- ${CFGS} --print native-static-libs 2>&1 \
+    | grep "native-static-libs" \
+    | sed "s/note: native-static-libs://" \
+    | sed "s/-lvlccore//" \
+    | sed 's/-framework [^ ]*//g')
 
 STATIC_LIB_NAME=$(echo $LT_CONVENIENCE | sed "s/\.la/\.a/")
 STATIC_LIB_DEP=$(echo $LT_CONVENIENCE | sed "s/\.la/\.d/")



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/d8746c8c90238267e4b6a8b985528188a31f6142

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/d8746c8c90238267e4b6a8b985528188a31f6142
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance