[vlc-commits] [Git][videolan/vlc][master] qt: remove explicit timeout in test_ml_model

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
81723f2b by Pierre Lamot at 2025-03-18T16:41:04+00:00
qt: remove explicit timeout in test_ml_model

Our CI tend to run tests extremely slowly when heavy loaded. Qt tests will
timeout by themselves after a global timeout and exit gracefully. As these
checks are not supposed to timeout we can just remove the explicit timeout with
no penalty for the case where the test runs under normal conditions.

fix: #29077

- - - - -


1 changed file:

- modules/gui/qt/tests/test_ml_model.cpp


Changes:

=====================================
modules/gui/qt/tests/test_ml_model.cpp
=====================================
@@ -175,10 +175,8 @@ private slots:
         const int high = 300;
         m_model->appendRange(low, high);
 
-        const int timeout = 1000;
-
         // let loading complete, getIndexFromID won't work for 'loading' model
-        QVERIFY(QTest::qWaitFor([this] () { return !m_model->loading(); }, timeout));
+        QVERIFY(QTest::qWaitFor([this] () { return !m_model->loading(); }));
 
         std::optional<int> row = -1;
         auto cb = [&row](std::optional<int> index)
@@ -190,7 +188,7 @@ private slots:
         m_model->getIndexFromId2(MLItemId{high, VLC_ML_PARENT_UNKNOWN}, cb);
 
         // NOTE: CI fails with QTRY_COMPARE_WITH_TIMEOUT
-        QVERIFY(QTest::qWaitFor([&row]() { return row != -1; }, timeout));
+        QVERIFY(QTest::qWaitFor([&row]() { return row != -1; }));
         QCOMPARE(row, high - 1);
 
         // above we must have loaded all the data, following this we should not need to wait for results



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/81723f2b5da71ca1b3ec797974285f8d3cbc819b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/81723f2b5da71ca1b3ec797974285f8d3cbc819b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance