[vlc-commits] [Git][videolan/vlc][master] 5 commits: qt: colorize `add.svg` in sout dialog

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
3523d0dc by Fatih Uzunoglu at 2025-03-24T09:30:03+00:00
qt: colorize `add.svg` in sout dialog

- - - - -
3b993d74 by Fatih Uzunoglu at 2025-03-24T09:30:03+00:00
qt: colorize `add.svg` in `FileOpenPanel`

- - - - -
7d2d392f by Fatih Uzunoglu at 2025-03-24T09:30:03+00:00
qt: colorize `add.svg` in plugin dialog

- - - - -
710b9ffc by Fatih Uzunoglu at 2025-03-24T09:30:03+00:00
qt: do not use unavailable `eject.svg` in `DiscOpenPanel`

- - - - -
eb1155a2 by Fatih Uzunoglu at 2025-03-24T09:30:03+00:00
qt: do not use unavailable `ic_fluent_arrow_shuffle_on.svg` in playlist menu

- - - - -


6 changed files:

- modules/gui/qt/dialogs/open/open_disk.ui
- modules/gui/qt/dialogs/open/open_file.ui
- modules/gui/qt/dialogs/open/open_panels.cpp
- modules/gui/qt/dialogs/plugins/plugins.cpp
- modules/gui/qt/dialogs/sout/sout.cpp
- modules/gui/qt/menus/qml_menu_wrapper.cpp


Changes:

=====================================
modules/gui/qt/dialogs/open/open_disk.ui
=====================================
@@ -159,10 +159,6 @@
           <property name="toolTip">
            <string>Eject the disc</string>
           </property>
-          <property name="icon">
-           <iconset resource="../../vlc.qrc">
-            <normaloff>:/menu/eject.svg</normaloff>:/menu/eject.svg</iconset>
-          </property>
          </widget>
         </item>
         <item>


=====================================
modules/gui/qt/dialogs/open/open_file.ui
=====================================
@@ -111,10 +111,6 @@
         <property name="text">
          <string>Add...</string>
         </property>
-        <property name="icon">
-         <iconset>
-          <normaloff>:/menu/add.svg</normaloff>:/menu/add.svg</iconset>
-        </property>
        </widget>
       </item>
       <item row="2" column="2">


=====================================
modules/gui/qt/dialogs/open/open_panels.cpp
=====================================
@@ -38,6 +38,7 @@
 #include "dialogs/dialogs_provider.hpp" /* Open Subtitle file */
 #include "util/qt_dirs.hpp"
 #include "util/validators.hpp"
+#include "util/colorizedsvgicon.hpp"
 #include <vlc_intf_strings.h>
 #include <vlc_modules.h>
 #include <vlc_plugin.h>
@@ -95,6 +96,8 @@ FileOpenPanel::FileOpenPanel( QWidget *_parent, qt_intf_t *_p_intf ) :
     /* Deactivate the subtitles control by default. */
     ui.subGroupBox->setEnabled( false );
 
+    ui.fileBrowseButton->setIcon( ColorizedSvgIcon::colorizedIconForWidget( ":/menu/add.svg", ui.fileBrowseButton ) );
+
     /* Connects  */
     BUTTONACT( ui.fileBrowseButton, &FileOpenPanel::browseFile );
     BUTTONACT( ui.removeFileButton, &FileOpenPanel::removeFile );
@@ -356,6 +359,8 @@ DiscOpenPanel::DiscOpenPanel( QWidget *_parent, qt_intf_t *_p_intf ) :
         ui.deviceCombo->setCurrentIndex( temp );
 #endif
 
+    ui.ejectButton->setIcon( ColorizedSvgIcon::colorizedIconForWidget( ":/menu/ic_fluent_arrow_eject.svg", ui.ejectButton ) );
+
     /* CONNECTs */
     BUTTONACT( ui.dvdRadioButton,     &DiscOpenPanel::updateButtons );
     BUTTONACT( ui.bdRadioButton,      &DiscOpenPanel::updateButtons );


=====================================
modules/gui/qt/dialogs/plugins/plugins.cpp
=====================================
@@ -32,6 +32,7 @@
 #include "network/addonsmodel.hpp"
 #include "widgets/native/animators.hpp"
 #include "util/imagehelper.hpp"
+#include "util/colorizedsvgicon.hpp"
 
 #include <cassert>
 
@@ -1048,8 +1049,10 @@ QWidget *AddonItemDelegate::createEditor( QWidget *parent,
             installButton = new QPushButton( QIcon( ":/menu/remove.svg" ),
                                              qtr("&Uninstall"), parent );
         else
-            installButton = new QPushButton( QIcon( ":/menu/add.svg" ),
-                                             qtr("&Install"), parent );
+        {
+            installButton = new QPushButton( qtr("&Install"), parent );
+            installButton->setIcon( ColorizedSvgIcon::colorizedIconForWidget( ":/menu/add.svg", installButton ) );
+        }
         connect( installButton, &QPushButton::clicked, this, &AddonItemDelegate::editButtonClicked );
         editorWidget->layout()->addWidget( installButton );
     }


=====================================
modules/gui/qt/dialogs/sout/sout.cpp
=====================================
@@ -30,6 +30,7 @@
 #include "util/qt_dirs.hpp"
 #include "dialogs/sout/sout_widgets.hpp"
 #include "widgets/native/qvlcframe.hpp"
+#include "util/colorizedsvgicon.hpp"
 
 #include <QString>
 
@@ -68,7 +69,7 @@ SoutDialog::SoutDialog( QWindow *parent, qt_intf_t *_p_intf, const QString& inpu
     QTabBar* tb = ui.destTab->findChild<QTabBar*>();
     if( tb != NULL ) tb->tabButton(0, QTabBar::RightSide)->hide();
     connect( ui.destTab, &QTabWidget::tabCloseRequested, this, &SoutDialog::closeTab );
-    ui.destTab->setTabIcon( 0, QIcon( ":/menu/add.svg" ) );
+    ui.destTab->setTabIcon( 0, ColorizedSvgIcon::colorizedIconForWidget( ":/menu/add.svg", ui.destTab ) );
 
     ui.destBox->addItem( qtr( "File" ) );
     ui.destBox->addItem( "HTTP" );


=====================================
modules/gui/qt/menus/qml_menu_wrapper.cpp
=====================================
@@ -1143,7 +1143,7 @@ void PlaylistContextMenu::popup(int selectedIndex, QPoint pos )
         }
 
         action = m_menu->addAction( qtr("Shuffle the playlist") );
-        action->setIcon(ColorizedSvgIcon::colorizedIconForWidget(":/menu/ic_fluent_arrow_shuffle_on.svg", m_menu.get()));
+        action->setIcon(ColorizedSvgIcon::colorizedIconForWidget(":/menu/ic_fluent_arrow_shuffle.svg", m_menu.get()));
         connect(action, &QAction::triggered, this, [this]( ) {
             m_controler->shuffle();
         });



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2804dc2688b0ca6eb7dca7c15b34cbf44f56d729...eb1155a2d70eccded0abf2defe17830f46762d37

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2804dc2688b0ca6eb7dca7c15b34cbf44f56d729...eb1155a2d70eccded0abf2defe17830f46762d37
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance