[vlc-commits] [Git][videolan/vlc][3.0.x] 3 commits: a52: disable by default

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
3a817551 by Thomas Guillem at 2025-05-12T15:07:36+02:00
a52: disable by default

This module has a lower priority than avcodec, therefore AC3 is almost
always decoded by avcodec. This module can be used if avcodec fails to
parse the codec, in that case, there are 3 possibles scenario:
 - liba52 can decode when ffmepg can't (very unlikely)
 - liba52 fails too (likely)
 - Security issue in liba52, possible since this library and module are
   not well tested and supported

- - - - -
bfb9e2fc by Thomas Guillem at 2025-05-12T15:07:36+02:00
dca: disable by default

This module has a lower priority than avcodec, therefore DTS is almost
always decoded by avcodec. This module can be used if avcodec fails to
parse the codec, in that case, there are 3 possibles scenario:
 - libdca can decode when ffmepg can't (very unlikely)
 - libdca fails too (likely)
 - Security issue in libdca, possible since this library and module are
   not well tested and supported

- - - - -
af4d43cd by Thomas Guillem at 2025-05-12T15:07:37+02:00
libmpeg2: disable by default

This module has a lower priority than avcodec, therefore MPEG2 is almost
always decoded by avcodec. This module can be used if avcodec fails to
parse the codec, in that case, there are 3 possibles scenario:
 - libmpeg2 can decode when ffmepg can't (very unlikely)
 - libmpeg2 fails too (likely)
 - Security issue in libmpeg2, possible since this library and module are
   not well tested and supported

- - - - -


7 changed files:

- Makefile.am
- configure.ac
- extras/package/os2/configure.sh
- extras/package/win32/configure.sh
- modules/codec/a52.c
- modules/codec/dca.c
- modules/codec/libmpeg2.c


Changes:

=====================================
Makefile.am
=====================================
@@ -25,12 +25,11 @@ SUFFIXES =
 
 DISTCHECK_CONFIGURE_FLAGS = \
 	--enable-fast-install \
-	--disable-a52 \
 	--disable-alsa \
 	--disable-avcodec --disable-avformat \
 	--disable-postproc --disable-swscale \
 	--disable-dbus \
-	--disable-mad --disable-libmpeg2 \
+	--disable-mad \
 	--disable-faad --disable-skins2 \
 	--disable-live555 \
 	--disable-lua \


=====================================
configure.ac
=====================================
@@ -2803,8 +2803,8 @@ dnl
 dnl A52/AC3 decoder plugin
 dnl
 AC_ARG_ENABLE(a52,
-  [  --enable-a52            A/52 support with liba52 (default enabled)])
-if test "${enable_a52}" != "no"
+  [  --enable-a52            A/52 support with liba52 (default disabled)])
+if test "${enable_a52}" = "yes"
 then
   AC_ARG_WITH(a52,
     [  --with-a52=PATH         a52 headers and libraries])
@@ -2836,7 +2836,7 @@ fi
 dnl
 dnl DTS Coherent Acoustics decoder plugin
 dnl
-PKG_ENABLE_MODULES_VLC([DCA], [dca], [libdca >= 0.0.5], [DTS Coherent Acoustics support with libdca], [auto])
+PKG_ENABLE_MODULES_VLC([DCA], [dca], [libdca >= 0.0.5], [DTS Coherent Acoustics support with libdca], [disabled])
 
 dnl
 dnl  Flac plugin
@@ -2846,7 +2846,7 @@ PKG_ENABLE_MODULES_VLC([FLAC], [], [flac], [libflac decoder/encoder support], [a
 dnl
 dnl  Libmpeg2 plugin
 dnl
-PKG_ENABLE_MODULES_VLC([LIBMPEG2], [], [libmpeg2 > 0.3.2], [libmpeg2 decoder support], [auto])
+PKG_ENABLE_MODULES_VLC([LIBMPEG2], [], [libmpeg2 > 0.3.2], [libmpeg2 decoder support], [disabled])
 
 dnl
 dnl  Vorbis plugin


=====================================
extras/package/os2/configure.sh
=====================================
@@ -19,9 +19,7 @@ OPTIONS="
       --enable-avformat
       --enable-swscale
       --enable-postproc
-      --enable-a52
       --enable-flac
-      --enable-libmpeg2
       --enable-vorbis
       --enable-png
       --enable-x264


=====================================
extras/package/win32/configure.sh
=====================================
@@ -7,7 +7,6 @@ OPTIONS="
       --enable-flac
       --enable-theora
       --enable-avcodec --enable-merge-ffmpeg
-      --enable-dca
       --enable-mpc
       --enable-libass
       --enable-schroedinger


=====================================
modules/codec/a52.c
=====================================
@@ -32,6 +32,8 @@
  * be subject to the terms of that later license.
  *****************************************************************************/
 
+#warning This module is not officially supported anymore
+
 #ifdef HAVE_CONFIG_H
 # include "config.h"
 #endif


=====================================
modules/codec/dca.c
=====================================
@@ -30,6 +30,8 @@
  * be subject to the terms of that later license.
  *****************************************************************************/
 
+#warning This module is not officially supported anymore
+
 #ifdef HAVE_CONFIG_H
 # include "config.h"
 #endif


=====================================
modules/codec/libmpeg2.c
=====================================
@@ -33,6 +33,9 @@
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
+
+#warning This module is not officially supported anymore
+
 #ifdef HAVE_CONFIG_H
 # include "config.h"
 #endif



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/504ffcaae914b91c7f61d92f6284f2a37af8b4d5...af4d43cd4aa05e59d681fcf230eb1b5c41787d31

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/504ffcaae914b91c7f61d92f6284f2a37af8b4d5...af4d43cd4aa05e59d681fcf230eb1b5c41787d31
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance