[vlc-commits] [Git][videolan/vlc][master] qt: use `QWidget::show()` instead of `QDialog::open()` for playlists dialog

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
fedb99dd by Fatih Uzunoglu at 2025-05-18T06:33:23+00:00
qt: use `QWidget::show()` instead of `QDialog::open()` for playlists dialog

So that the dialog respects its modality. The add to playlist dialog should
be modeless, especially now that it is no longer a singleton.

I previously used `QDialog::open()` because it is specific to `QDialog`,
unlike `QWidget::show()`, but I did not realize that `QDialog::open()` does
not respect the modality and always shows the dialog modal.

- - - - -


1 changed file:

- modules/gui/qt/dialogs/dialogs_provider.cpp


Changes:

=====================================
modules/gui/qt/dialogs/dialogs_provider.cpp
=====================================
@@ -415,7 +415,7 @@ void DialogsProvider::playlistsDialog( const QVariantList & medias, MLPlaylistLi
 {
     const auto dialog = new PlaylistsDialog(p_intf, medias, type);
     dialog->setAttribute(Qt::WA_DeleteOnClose);
-    dialog->open();
+    dialog->show(); // "Modeless dialogs are displayed using show()"
 }
 
 void DialogsProvider::bookmarksDialog()



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fedb99dd83f6a88d4c43d46e3bce6070ed79a8ea

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fedb99dd83f6a88d4c43d46e3bce6070ed79a8ea
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance