[vlc-commits] [Git][videolan/vlc][master] bluray: don't assert on i_plane > MAX_OVERLAY

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
7e48e222 by Khalid Masum at 2025-11-09T18:57:31+00:00
bluray: don't assert on i_plane > MAX_OVERLAY

Otherwise it'll cause out of bound read at assertion
when deleting overlay.

Fixes: #29378 (Coverity: 1666172)

- - - - -


1 changed file:

- modules/access/bluray.c


Changes:

=====================================
modules/access/bluray.c
=====================================
@@ -1482,12 +1482,13 @@ static int bluray_esOutControl(es_out_t *p_out, input_source_t *in, int i_query,
                                        esout_priv->overlay.p_video_es,
                                        esout_priv->overlay.channels[i_plane]);
                 esout_priv->overlay.channels[i_plane] = VOUT_SPU_CHANNEL_INVALID;
+                break;
             }
-            else
+            if (likely(i_plane < MAX_OVERLAY))
             {
                 assert((ssize_t)esout_priv->overlay.channels[i_plane] == VOUT_SPU_CHANNEL_INVALID);
-                i_ret = VLC_EGENERIC;
             }
+            i_ret = VLC_EGENERIC;
             break;
         }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e48e222b789b44dc766f815246e763ca9d1bb87

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e48e222b789b44dc766f815246e763ca9d1bb87
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance