[vlc-commits] [Git][videolan/vlc][master] decoder: reset error state on flush

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
df2439ec by Thomas Guillem at 2025-11-11T21:02:59+02:00
decoder: reset error state on flush

Errors come most likely from modules returning VLCDEC_ECRITICAL. In case
of memory or parsing issue.

A flush could reset this error state, allowing playback to continue
after a seek.

We could debate whether we should distinguish ENOMEM from
VLCDEC_ECRITICAL when reseting the error. But it is also possible to
reset a memory error state after a flush.

- - - - -


1 changed file:

- src/input/decoder.c


Changes:

=====================================
src/input/decoder.c
=====================================
@@ -1749,14 +1749,13 @@ static void DecoderThread_Flush( vlc_input_decoder_t *p_owner )
     decoder_t *p_dec = &p_owner->dec;
     decoder_t *p_packetizer = p_owner->p_packetizer;
 
-    if( p_owner->error )
-        return;
-
     if( p_packetizer != NULL && p_packetizer->pf_flush != NULL )
         p_packetizer->pf_flush( p_packetizer );
 
     if ( p_dec->pf_flush != NULL )
         p_dec->pf_flush( p_dec );
+
+    p_owner->error = false;
 }
 
 /**



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/df2439ec19fc1415b006475d24452c16e9a47aa4

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/df2439ec19fc1415b006475d24452c16e9a47aa4
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance