[vlc-commits] [Git][videolan/vlc][master] qt: increase the csd window margin on wayland

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
323240ed by Fatih Uzunoglu at 2025-11-17T03:10:07+00:00
qt: increase the csd window margin on wayland

This is done to make the csd shadow look more natural,
as with the current margin the blur/glow radius has to
be quite limited for the shadows to fit in the window.

Currently window managers/compositors even use layered
shadows (stacking of multiple shadows), so having one
shadow that is concentrated looks odd in 2025. After
this, we should also consider if we want to follow a
similar approach. We currently have `DoubleShadow`,
perhaps that would be nice to use it, at least as the
first step.

I have done this only on Wayland (not X11) because there
we use input mask to let the events pass through beyond
the csd resize area (`MainCtx.csdBorderSize`). This means
that we are practically free with regard to the margins,
if we want it can be bigger.

Whereas on X11 we have to use a reasonable window margin,
because the window would receive the input events also
in this region. Even though we don't really consume the
input events in this region in the application, these
events are not passed to what is available behind. I
don't know if this is just how X11 behaves, or it is a
Qt bug that Qt windows consume input events whether or
not the application itself used/consumed them.

- - - - -


1 changed file:

- modules/gui/qt/maininterface/qml/MainInterface.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/MainInterface.qml
=====================================
@@ -98,7 +98,7 @@ Item {
         Binding {
             target: MainCtx
             property: "windowExtendedMargin"
-            value: _extendedFrameVisible ? 20 : 0
+            value: _extendedFrameVisible ? (Qt.platform.pluginName.startsWith("wayland") ? 40 : 20) : 0
         }
 
         Window.onWindowChanged: {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/323240ed11b9b856355ad0e4c45871c181ca7350

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/323240ed11b9b856355ad0e4c45871c181ca7350
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance