[vlc-commits] [Git][videolan/vlc][master] codec: webvtt: remove dead code in domnode match attribute

Steve Lhomme (@robUx4) gitlab at videolan.org
Fri Nov 28 11:39:01 UTC 2025



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
e3353f3e by Khalid Masum at 2025-11-28T10:53:19+00:00
codec: webvtt: remove dead code in domnode match attribute

fixes: #29335 (coverity: 1666285)

Co-authored-by: Syed Shams Islam <isyed4916 at gmail.com>

- - - - -


1 changed file:

- modules/codec/webvtt/subsvtt.c


Changes:

=====================================
modules/codec/webvtt/subsvtt.c
=====================================
@@ -777,9 +777,6 @@ static bool webvtt_domnode_Match_Attribute( const webvtt_dom_node_t *p_node,
             if( psz_start == NULL || *psz_start == 0 )
                 psz_start = p_tagnode->psz_attrs;
 
-            if( !p_matchsel ) /* attribute check only */
-                return *psz_start != '\0';
-
             return MatchAttribute( psz_start, p_matchsel->psz_name, p_matchsel->match );
         }
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e3353f3e9155c92d6909d38fe09de5e78ace2a43

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e3353f3e9155c92d6909d38fe09de5e78ace2a43
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list