[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Fix sizing of mute volume button in main video view
Steve Lhomme (@robUx4)
gitlab at videolan.org
Wed Oct 1 08:30:47 UTC 2025
Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
5bea3500 by Claudio Cambra at 2025-10-01T08:09:21+00:00
macosx: Fix sizing of mute volume button in main video view
Signed-off-by: Claudio Cambra <developer at claudiocambra.com>
- - - - -
2e3d9f8c by Claudio Cambra at 2025-10-01T08:09:21+00:00
macosx: Also resize the jump forward/jump backward buttons in the main video view
Signed-off-by: Claudio Cambra <developer at claudiocambra.com>
- - - - -
3 changed files:
- modules/gui/macosx/UI/VLCMainVideoView.xib
- modules/gui/macosx/windows/video/VLCMainVideoViewController.h
- modules/gui/macosx/windows/video/VLCMainVideoViewController.m
Changes:
=====================================
modules/gui/macosx/UI/VLCMainVideoView.xib
=====================================
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
-<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="24112" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="24127" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
<dependencies>
<deployment version="101000" identifier="macosx"/>
- <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="24112"/>
+ <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="24127"/>
<capability name="Image references" minToolsVersion="12.0"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
@@ -16,6 +16,8 @@
<outlet property="fakeTitleBar" destination="jnw-gL-nrF" id="7lZ-al-c3d"/>
<outlet property="fakeTitleBarHeightConstraint" destination="wY4-If-nIp" id="wPt-X4-mgu"/>
<outlet property="floatOnTopIndicatorImageView" destination="CrW-mq-gge" id="hqR-4Z-a18"/>
+ <outlet property="jumpBackwardButtonSizeConstraint" destination="Xh5-1i-dxH" id="AZa-08-Q0X"/>
+ <outlet property="jumpForwardButtonSizeConstraint" destination="OBA-WG-jaz" id="03p-9F-1ex"/>
<outlet property="loadingIndicator" destination="xOQ-YR-iAc" id="CtX-Yo-UX2"/>
<outlet property="mainControlsView" destination="D4V-Zd-qvB" id="KwM-ya-ETn"/>
<outlet property="nextButtonSizeConstraint" destination="M5n-CD-fd3" id="WIM-QF-IMG"/>
@@ -215,24 +217,24 @@
<action selector="toggleFloatOnTop:" target="3" id="BvH-qi-jx1"/>
</connections>
</button>
- <button wantsLayer="YES" horizontalHuggingPriority="1000" verticalHuggingPriority="750" horizontalCompressionResistancePriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="dYZ-ri-Kra" customClass="VLCImageButton">
- <rect key="frame" x="303" y="0.0" width="44" height="28"/>
- <buttonCell key="cell" type="recessed" bezelStyle="recessed" image="arrow.up.left.and.arrow.down.right" catalog="system" imagePosition="only" alignment="center" controlSize="large" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="Z8g-js-0W6">
+ <button wantsLayer="YES" horizontalHuggingPriority="1000" verticalHuggingPriority="750" horizontalCompressionResistancePriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="yEi-SZ-SIS" customClass="VLCImageButton">
+ <rect key="frame" x="303" y="0.0" width="48" height="28"/>
+ <buttonCell key="cell" type="recessed" bezelStyle="recessed" image="pip.enter" catalog="system" imagePosition="only" alignment="center" controlSize="large" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="Q7p-GS-7p0">
<behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES" changeBackground="YES" changeGray="YES"/>
<font key="font" metaFont="system"/>
</buttonCell>
<connections>
- <action selector="fullscreen:" target="3" id="0Kk-UV-WtF"/>
+ <action selector="onPipButtonClick:" target="3" id="2Yi-Jo-2No"/>
</connections>
</button>
- <button wantsLayer="YES" horizontalHuggingPriority="1000" verticalHuggingPriority="750" horizontalCompressionResistancePriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="yEi-SZ-SIS" customClass="VLCImageButton">
- <rect key="frame" x="352" y="0.0" width="47" height="28"/>
- <buttonCell key="cell" type="recessed" bezelStyle="recessed" image="pip.enter" catalog="system" imagePosition="only" alignment="center" controlSize="large" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="Q7p-GS-7p0">
+ <button wantsLayer="YES" horizontalHuggingPriority="1000" verticalHuggingPriority="750" horizontalCompressionResistancePriority="1000" translatesAutoresizingMaskIntoConstraints="NO" id="dYZ-ri-Kra" customClass="VLCImageButton">
+ <rect key="frame" x="356" y="0.0" width="43" height="28"/>
+ <buttonCell key="cell" type="recessed" bezelStyle="recessed" image="arrow.up.left.and.arrow.down.right" catalog="system" imagePosition="only" alignment="center" controlSize="large" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="Z8g-js-0W6">
<behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES" changeBackground="YES" changeGray="YES"/>
<font key="font" metaFont="system"/>
</buttonCell>
<connections>
- <action selector="onPipButtonClick:" target="3" id="2Yi-Jo-2No"/>
+ <action selector="fullscreen:" target="3" id="0Kk-UV-WtF"/>
</connections>
</button>
</subviews>
@@ -303,6 +305,9 @@
</customSpacing>
</stackView>
</subviews>
+ <constraints>
+ <constraint firstItem="afi-4d-rQk" firstAttribute="height" secondItem="dYZ-ri-Kra" secondAttribute="height" id="ISh-e8-r9g"/>
+ </constraints>
<visibilityPriorities>
<integer value="1000"/>
<integer value="1000"/>
=====================================
modules/gui/macosx/windows/video/VLCMainVideoViewController.h
=====================================
@@ -59,6 +59,8 @@ extern NSString * const VLCUseClassicVideoPlayerLayoutKey;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *playButtonSizeConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *prevButtonSizeConstraint;
@property (readwrite, weak) IBOutlet NSLayoutConstraint *nextButtonSizeConstraint;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpBackwardButtonSizeConstraint;
+ at property (readwrite, weak) IBOutlet NSLayoutConstraint *jumpForwardButtonSizeConstraint;
@property (readwrite, strong) IBOutlet NSLayoutConstraint *centerButtonStackInViewConstraint;
@property (readonly) NSLayoutConstraint *bottomButtonStackViewConstraint;
=====================================
modules/gui/macosx/windows/video/VLCMainVideoViewController.m
=====================================
@@ -279,6 +279,8 @@ NSString * const VLCUseClassicVideoPlayerLayoutKey = @"VLCUseClassicVideoPlayerL
self.prevButtonSizeConstraint.constant = VLCLibraryUIUnits.smallPlaybackControlButtonSize;
self.playButtonSizeConstraint.constant = VLCLibraryUIUnits.smallPlaybackControlButtonSize;
self.nextButtonSizeConstraint.constant = VLCLibraryUIUnits.smallPlaybackControlButtonSize;
+ self.jumpBackwardButtonSizeConstraint.constant = VLCLibraryUIUnits.smallPlaybackControlButtonSize;
+ self.jumpForwardButtonSizeConstraint.constant = VLCLibraryUIUnits.smallPlaybackControlButtonSize;
[self applyAudioDecorativeViewForegroundCoverArtViewConstraints];
} else {
[self setAutohideControls:YES];
@@ -287,6 +289,8 @@ NSString * const VLCUseClassicVideoPlayerLayoutKey = @"VLCUseClassicVideoPlayerL
self.prevButtonSizeConstraint.constant = VLCLibraryUIUnits.mediumPlaybackControlButtonSize;
self.playButtonSizeConstraint.constant = VLCLibraryUIUnits.largePlaybackControlButtonSize;
self.nextButtonSizeConstraint.constant = VLCLibraryUIUnits.mediumPlaybackControlButtonSize;
+ self.jumpBackwardButtonSizeConstraint.constant = VLCLibraryUIUnits.mediumPlaybackControlButtonSize;
+ self.jumpForwardButtonSizeConstraint.constant = VLCLibraryUIUnits.mediumPlaybackControlButtonSize;
}
}
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c5c916524f33b3313bcf879a012480304f30f38f...2e3d9f8c833056367cb6097dd87de09740f55112
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c5c916524f33b3313bcf879a012480304f30f38f...2e3d9f8c833056367cb6097dd87de09740f55112
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance
More information about the vlc-commits
mailing list