[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: make the visual visible when image reports readiness in `ImageExt`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
75c368c2 by Fatih Uzunoglu at 2025-10-03T08:41:12+00:00
qml: make the visual visible when image reports readiness in `ImageExt`

If a texture provider does not provide a texture, a black texture is
generated and used instead. This behavior makes it not consistent with
`Image`, where it would not show anything.

- - - - -
67e787ca by Fatih Uzunoglu at 2025-10-03T08:41:12+00:00
qml: probe fallback first for effective radius in `MediaCover`

This is because if main image is not available, it still has
`visible` set whereas fallback image has `visible` set when it
is actually used.

- - - - -


2 changed files:

- modules/gui/qt/widgets/qml/ImageExt.qml
- modules/gui/qt/widgets/qml/MediaCover.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/ImageExt.qml
=====================================
@@ -158,7 +158,8 @@ Item {
 
         visible: readyForVisibility
 
-        readonly property bool readyForVisibility: (GraphicsInfo.shaderType === GraphicsInfo.RhiShader) &&
+        readonly property bool readyForVisibility: (image.status === Image.Ready) /* TODO: investigate using TextureProviderObserver::isValid instead */ &&
+                                                   (GraphicsInfo.shaderType === GraphicsInfo.RhiShader) &&
                                                    (root.radius > 0.0 || root.borderWidth > 0 || backgroundColor.a > 0.0 || root.fillMode === Image.PreserveAspectCrop)
 
         smooth: root.smooth


=====================================
modules/gui/qt/widgets/qml/MediaCover.qml
=====================================
@@ -34,8 +34,8 @@ Item {
 
     property bool playCoverShowPlay: true
 
-    readonly property real effectiveRadius: image.visible ? image.effectiveRadius
-                                                          : (fallbackImage.visible ? fallbackImage.effectiveRadius
+    readonly property real effectiveRadius: fallbackImage.visible ? fallbackImage.effectiveRadius
+                                                                  : (image.visible ? image.effectiveRadius
                                                                                    : 0.0)
 
     readonly property real eDPR: MainCtx.effectiveDevicePixelRatio(Window.window)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/383aca8e64e3ed25d939f98dbfc644d960f7ef1d...67e787ca0d9eef28ba410befa6669c4eef0d8489

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/383aca8e64e3ed25d939f98dbfc644d960f7ef1d...67e787ca0d9eef28ba410befa6669c4eef0d8489
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance