[vlc-commits] [Git][videolan/vlc][master] qml: do not load the fallback image during initialization in `ArtistTopBanner`

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
8be3f74f by Fatih Uzunoglu at 2025-10-05T09:34:31+00:00
qml: do not load the fallback image during initialization in `ArtistTopBanner`

This prevents twitching and loading an image just to potentially discard it
after the initialization completes, which takes just a moment.

- - - - -


1 changed file:

- modules/gui/qt/medialibrary/qml/ArtistTopBanner.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/ArtistTopBanner.qml
=====================================
@@ -58,7 +58,7 @@ FocusScope {
         anchors.fill: parent
 
         asynchronous: true
-        source: artist.cover || VLCStyle.noArtArtist
+        source: root.artist.id ? (root.artist.cover || VLCStyle.noArtArtist) : "" // do not load the fallback image during initialization
         sourceSize: artist.cover ? Qt.size(Helpers.alignUp(Screen.desktopAvailableWidth, 32), 0)
                                  : undefined
         mipmap: !!artist.cover
@@ -160,7 +160,7 @@ FocusScope {
 
             Widgets.ImageExt {
                 id: roundImage
-                source: artist.cover || VLCStyle.noArtArtist
+                source: root.artist.id ? (root.artist.cover || VLCStyle.noArtArtist) : "" // do not load the fallback image during initialization
                 sourceSize: Qt.size(width * eDPR, height * eDPR)
                 anchors.fill: parent
                 radius: VLCStyle.cover_normal



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8be3f74f504f7e782f43e8215f38ff1dd034e6ac

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8be3f74f504f7e782f43e8215f38ff1dd034e6ac
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance