[vlc-commits] [Git][videolan/vlc][master] 2 commits: video_chroma/gst: fix p_chain leak

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
10d70581 by Johannes Kauffmann at 2025-10-09T08:21:52+00:00
video_chroma/gst: fix p_chain leak

- - - - -
4787f401 by Johannes Kauffmann at 2025-10-09T08:21:52+00:00
canvas: fix p_chain leak

- - - - -


2 changed files:

- modules/video_chroma/gst_mem.c
- modules/video_filter/canvas.c


Changes:

=====================================
modules/video_chroma/gst_mem.c
=====================================
@@ -103,11 +103,17 @@ static int Open(filter_t *p_filter)
     ret = filter_chain_AppendConverter(p_chain, &fmt_intermediate);
     es_format_Clean(&fmt_intermediate);
     if (ret != VLC_SUCCESS)
+    {
+        filter_chain_Delete(p_chain);
         return ret;
+    }
 
     ret = filter_chain_AppendConverter(p_chain, NULL);
     if (ret != VLC_SUCCESS)
+    {
+        filter_chain_Delete(p_chain);
         return ret;
+    }
 
     p_filter->p_sys = p_chain;
     p_filter->ops = &chain_ops;


=====================================
modules/video_filter/canvas.c
=====================================
@@ -345,6 +345,7 @@ static int Activate( filter_t *p_filter )
     if ( ret != VLC_SUCCESS )
     {
         msg_Err( p_filter, "Could not append scaling filter" );
+        filter_chain_Delete( p_sys->p_chain );
         free( p_sys );
         return ret;
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/40e476ad7460f3155176c0b71c276a8f779f5aef...4787f40122d16cc9385781903aee55deb525f6d7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/40e476ad7460f3155176c0b71c276a8f779f5aef...4787f40122d16cc9385781903aee55deb525f6d7
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance