[vlc-commits] [Git][videolan/vlc][master] libass: fix possible nullptr deref

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0b783169 by Khalid Masum at 2025-10-11T07:43:21+00:00
libass: fix possible nullptr deref

vlc_stream_MemoryNew may return NULL. Which could be dereferenced
by vlc_stream_ReadLine calls in OldEngineClunkyRollInfoPatch.

Fixes: #29363 (Coverity 1666281)

- - - - -


1 changed file:

- modules/codec/libass.c


Changes:

=====================================
modules/codec/libass.c
=====================================
@@ -764,6 +764,9 @@ static void OldEngineClunkyRollInfoPatch( decoder_t *p_dec, ASS_Track *p_track )
 
     stream_t *p_memstream = vlc_stream_MemoryNew( p_dec, p_dec->fmt_in->p_extra,
                                                   p_dec->fmt_in->i_extra, true );
+    if (unlikely(!p_memstream))
+        return;
+
     char *s = vlc_stream_ReadLine( p_memstream );
     unsigned playres[2] = {0, 0};
     bool b_hotfix = false;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0b7831694bbee4e001aede459f76d1d0da74f2e4

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0b7831694bbee4e001aede459f76d1d0da74f2e4
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance