[vlc-commits] [Git][videolan/vlc][master] 9 commits: macosx: Fix new warnings emitted in VLCInputItem

Steve Lhomme (@robUx4) gitlab at videolan.org
Mon Oct 27 18:21:33 UTC 2025 


Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
5487a48b by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Fix new warnings emitted in VLCInputItem

Fixes:

In file included from /Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/playqueue/VLCPlayerController.m:31:
/Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/library/VLCInputItem.h:91:32: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   91 | NSDictionary<NSString *, id> * const commonInputItemData(NSArray<VLCInputItem*> * const inputItems);

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
fbde7382 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Remove unnecessary semicolon in VLCStatusBarIcon init

Fixes:

/Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/menus/VLCStatusBarIcon.m:76:43: warning: semicolon before method body is ignored [-Wsemicolon-before-method-body]
   76 | - (instancetype)init:(intf_thread_t *)intf;
      |                                           ^

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ded51c06 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Mark unused block parameters as unused

Fixes:

/Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/library/media-source/VLCMediaSourceCollectionViewItem.m:215:58: warning: unused parameter 'idx' [-Wunused-parameter]
  215 |         VLCInputItem * const inputItem, const NSUInteger idx, BOOL * const stop
      |                                                          ^
/Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/library/media-source/VLCMediaSourceCollectionViewItem.m:215:76: warning: unused parameter 'stop' [-Wunused-parameter]
  215 |         VLCInputItem * const inputItem, const NSUInteger idx, BOOL * const stop
      |                                                                            ^

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
54a6aba6 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Remove all semicolons before method bodies

Fixes:

/Users/claudio/Developer/vlc/extras/package/macosx/../../../modules/gui/macosx/windows/controlsbar/VLCMainWindowControlsBar.m:175:73: warning: semicolon before method body is ignored [-Wsemicolon-before-method-body]
  175 | - (void)updateCurrentItemDisplayControls:(NSNotification *)aNotification;
      |                                                                         ^

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e28c0058 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Fix unused variables

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e959928c by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Fix number type warnings

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7dec2632 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Remove unused addShadow function

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
56aba5c3 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Mark unused parameters in C callbacks with __unused

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
b8200740 by Claudio Cambra at 2025-10-27T18:01:18+00:00
macosx: Fix setters not applying values on ivars

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


42 changed files:

- modules/gui/macosx/extensions/NSIndexSet+VLCAdditions.m
- modules/gui/macosx/library/VLCInputItem.h
- modules/gui/macosx/library/VLCInputItem.m
- modules/gui/macosx/library/VLCInputNodePathControl.m
- modules/gui/macosx/library/VLCLibraryAbstractGroupingDataSource.m
- modules/gui/macosx/library/VLCLibraryCollectionViewItem.m
- modules/gui/macosx/library/VLCLibraryDataTypes.m
- modules/gui/macosx/library/VLCLibraryHeroView.m
- modules/gui/macosx/library/VLCLibraryItemInternalMediaItemsDataSource.m
- modules/gui/macosx/library/VLCLibraryMenuController.m
- modules/gui/macosx/library/VLCLibraryModel.m
- modules/gui/macosx/library/VLCLibraryRepresentedItem.m
- modules/gui/macosx/library/VLCLibraryTableCellView.m
- modules/gui/macosx/library/VLCLibraryTableView.m
- modules/gui/macosx/library/VLCLibraryTableViewDelegate.m
- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/library/VLCLibraryWindowNavigationSidebarOutlineView.m
- modules/gui/macosx/library/VLCLibraryWindowNavigationSidebarViewController.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioDataSource.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioGroupDataSource.m
- modules/gui/macosx/library/favorites-library/VLCLibraryFavoritesDataSource.m
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewStackViewController.m
- modules/gui/macosx/library/home-library/VLCLibraryHomeViewVideoContainerViewDataSource.m
- modules/gui/macosx/library/media-source/VLCLibraryMediaSourceViewNavigationStack.m
- modules/gui/macosx/library/media-source/VLCMediaSource.m
- modules/gui/macosx/library/media-source/VLCMediaSourceCollectionViewItem.m
- modules/gui/macosx/library/media-source/VLCMediaSourceDataSource.m
- modules/gui/macosx/library/playlist-library/VLCLibraryPlaylistDataSource.m
- modules/gui/macosx/library/video-library/VLCLibraryShowsDataSource.m
- modules/gui/macosx/library/video-library/VLCLibraryVideoDataSource.m
- modules/gui/macosx/menus/VLCStatusBarIcon.m
- modules/gui/macosx/os-integration/VLCRemoteControlService.m
- modules/gui/macosx/panels/bookmarks/VLCBookmarksTableViewDataSource.m
- modules/gui/macosx/playqueue/VLCPlayQueueController.m
- modules/gui/macosx/playqueue/VLCPlayQueueDataSource.m
- modules/gui/macosx/playqueue/VLCPlayQueueMenuController.m
- modules/gui/macosx/playqueue/VLCPlaybackContinuityController.m
- modules/gui/macosx/playqueue/VLCPlayerController.m
- modules/gui/macosx/views/VLCPlaybackEndViewController.m
- modules/gui/macosx/windows/controlsbar/VLCControlsBarCommon.m
- modules/gui/macosx/windows/controlsbar/VLCMainWindowControlsBar.m
- modules/gui/macosx/windows/video/VLCMainVideoViewController.m


The diff was not included because it is too large.


View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/52c61546c2f84a39ad91ef5a4780344014da0455...b82007408b72172298101ace34d91c15a7558a3e

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/52c61546c2f84a39ad91ef5a4780344014da0455...b82007408b72172298101ace34d91c15a7558a3e
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance

More information about the vlc-commits mailing list