[vlc-commits] [Git][videolan/vlc][master] contrib: breakpad: fix support for Windows ARM64

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0362008d by Steve Lhomme at 2025-09-13T06:42:43+00:00
contrib: breakpad: fix support for Windows ARM64

- - - - -


2 changed files:

- contrib/src/breakpad/rules.mak
- + contrib/src/breakpad/windows-arm64.patch


Changes:

=====================================
contrib/src/breakpad/rules.mak
=====================================
@@ -17,6 +17,7 @@ breakpad: breakpad-$(BREAKPAD_VERSION).tar.gz .sum-breakpad
 	$(UNPACK)
 	# $(call update_autoconfig,autotools)
 	$(APPLY) $(SRC)/breakpad/0001-mac-client-Upgrade-Breakpad.xib-to-new-format.patch
+	$(APPLY) $(SRC)/breakpad/windows-arm64.patch
 	sed -i.orig -e "s/GCC_TREAT_WARNINGS_AS_ERRORS = YES/GCC_TREAT_WARNINGS_AS_ERRORS = NO/" "$(UNPACK_DIR)/src/common/mac/Breakpad.xcconfig"
 	$(MOVE)
 


=====================================
contrib/src/breakpad/windows-arm64.patch
=====================================
@@ -0,0 +1,28 @@
+From b988fa74ec18de6214b18f723e48331d9a7802ae Mon Sep 17 00:00:00 2001
+From: Tom Tan <Tom.Tan at microsoft.com>
+Date: Wed, 2 Jan 2019 15:06:59 -0800
+Subject: [PATCH] Extract intruction pointer correctly for Windows ARM64
+
+Bug: 893460
+Change-Id: Ibbdf734e72c29c4779b6a701dceec1626056a9ba
+Reviewed-on: https://chromium-review.googlesource.com/c/1393763
+Reviewed-by: Joshua Peraza <jperaza at chromium.org>
+---
+ src/client/windows/handler/exception_handler.cc | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/client/windows/handler/exception_handler.cc b/src/client/windows/handler/exception_handler.cc
+index c369b65d6..ad45b2000 100644
+--- a/src/client/windows/handler/exception_handler.cc
++++ b/src/client/windows/handler/exception_handler.cc
+@@ -976,7 +976,9 @@ bool ExceptionHandler::WriteMinidumpWithExceptionForProcess(
+ #if defined(_M_IX86)
+           exinfo->ContextRecord->Eip;
+ #elif defined(_M_AMD64)
+-        exinfo->ContextRecord->Rip;
++          exinfo->ContextRecord->Rip;
++#elif defined(_M_ARM64)
++          exinfo->ContextRecord->Pc;
+ #else
+ #error Unsupported platform
+ #endif



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0362008d572df3c1f9ad23441dd59de2184374d1

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0362008d572df3c1f9ad23441dd59de2184374d1
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance