[vlc-commits] [Git][videolan/vlc][master] audio_filter: ebur128: fix missing error handling

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
73ab0a48 by Marvin Scholz at 2025-09-23T13:59:56+00:00
audio_filter: ebur128: fix missing error handling

Errors where checked but not assigned, making the checks effectively
dead code. Fixed by adding the missing assignments.

Fix CID 1665567

- - - - -


1 changed file:

- modules/audio_filter/libebur128.c


Changes:

=====================================
modules/audio_filter/libebur128.c
=====================================
@@ -60,10 +60,10 @@ CreateEbuR128State(filter_t *filter, int mode)
         error = ebur128_set_channel(state, 2, EBUR128_LEFT_SURROUND);
         if (error != EBUR128_SUCCESS)
             goto error;
-        ebur128_set_channel(state, 3, EBUR128_RIGHT_SURROUND);
+        error = ebur128_set_channel(state, 3, EBUR128_RIGHT_SURROUND);
         if (error != EBUR128_SUCCESS)
             goto error;
-        ebur128_set_channel(state, 4, EBUR128_CENTER);
+        error = ebur128_set_channel(state, 4, EBUR128_CENTER);
         if (error != EBUR128_SUCCESS)
             goto error;
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/73ab0a48ee0840d68ade8c9c187c3ae3bbbf335c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/73ab0a48ee0840d68ade8c9c187c3ae3bbbf335c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance