[vlc-commits] [Git][videolan/vlc][master] move unused before return

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
2b011c1f by Steve Lhomme at 2025-09-24T09:07:50+00:00
move unused before return

Coverity issues a dead code error.

- - - - -


10 changed files:

- modules/demux/mock.c
- modules/stream_out/chromaprint.c
- modules/stream_out/duplicate.c
- modules/stream_out/es.c
- modules/stream_out/hls/subtitles_segmenter.c
- modules/stream_out/mosaic_bridge.c
- modules/stream_out/smem.c
- modules/stream_out/stats.c
- src/player/aout.c
- src/player/player.c


Changes:

=====================================
modules/demux/mock.c
=====================================
@@ -799,8 +799,8 @@ CreateSubBlock(demux_t *demux, struct mock_track *track)
     b->i_buffer = len;
 
     free(text);
-    return b;
     (void) track;
+    return b;
 }
 
 static int


=====================================
modules/stream_out/chromaprint.c
=====================================
@@ -203,8 +203,8 @@ Add( sout_stream_t *p_stream, const es_format_t *p_fmt, const char *es_id )
 
 error:
     free( id );
-    return NULL;
     (void)es_id;
+    return NULL;
 }
 
 static void Del( sout_stream_t *p_stream, void *id )


=====================================
modules/stream_out/duplicate.c
=====================================
@@ -199,8 +199,8 @@ static int Control( sout_stream_t *p_stream, int i_query, va_list args )
         }
     }
 
-    return VLC_EGENERIC;
     (void)p_stream;
+    return VLC_EGENERIC;
 }
 
 /*****************************************************************************
@@ -467,8 +467,8 @@ static int Send( sout_stream_t *p_stream, void *_id, vlc_frame_t *frame )
         sout_StreamIdSend( dup_id->stream_owner, dup_id->id, to_send );
     }
 
-    return VLC_SUCCESS;
     (void)p_stream;
+    return VLC_SUCCESS;
 }
 
 static void SetPCR( sout_stream_t *stream, vlc_tick_t pcr )


=====================================
modules/stream_out/es.c
=====================================
@@ -241,8 +241,8 @@ Add( sout_stream_t *p_stream, const es_format_t *p_fmt, const char *es_id )
     }
 
     p_sys->count_sync += id->synchronous;
-    return id;
     (void)es_id;
+    return id;
 }
 
 static void Del( sout_stream_t *p_stream, void *_id )


=====================================
modules/stream_out/hls/subtitles_segmenter.c
=====================================
@@ -291,8 +291,8 @@ static int hls_sub_segmenter_Control(sout_mux_t *mux, int query, va_list args)
         return VLC_ENOTSUP;
 
     *(va_arg(args, bool *)) = false;
-    return VLC_SUCCESS;
     (void)mux;
+    return VLC_SUCCESS;
 }
 
 sout_mux_t *CreateSubtitleSegmenter(sout_access_out_t *access,


=====================================
modules/stream_out/mosaic_bridge.c
=====================================
@@ -273,8 +273,8 @@ Add( sout_stream_t *p_stream, const es_format_t *p_fmt, const char *es_id )
 
     msg_Dbg( p_stream, "mosaic bridge id=%s pos=%d", p_es->psz_id, i );
 
-    return p_owner;
     (void)es_id;
+    return p_owner;
 }
 
 static void Del( sout_stream_t *p_stream, void *id )


=====================================
modules/stream_out/smem.c
=====================================
@@ -289,8 +289,8 @@ Add(sout_stream_t *p_stream, const es_format_t *p_fmt, const char *es_id)
         id = AddVideo( p_stream, p_fmt );
     else if ( p_fmt->i_cat == AUDIO_ES )
         id = AddAudio( p_stream, p_fmt );
-    return id;
     (void)es_id;
+    return id;
 }
 
 static void *AddVideo( sout_stream_t *p_stream, const es_format_t *p_fmt )


=====================================
modules/stream_out/stats.c
=====================================
@@ -88,8 +88,8 @@ Add( sout_stream_t *p_stream, const es_format_t *p_fmt, const char *es_id )
     vlc_hash_md5_Init( &id->hash );
 
     msg_Dbg( p_stream, "%s: Adding track type:%s id:%d", p_sys->prefix, id->type, id->id);
-    return id;
     (void)es_id;
+    return id;
 }
 
 static void Del( sout_stream_t *p_stream, void *_id )


=====================================
src/player/aout.c
=====================================
@@ -115,8 +115,8 @@ vlc_player_AoutCallback(vlc_object_t *this, const char *var,
     else
         vlc_assert_unreachable();
 
-    return VLC_SUCCESS;
     (void) this;
+    return VLC_SUCCESS;
 }
 
 float


=====================================
src/player/player.c
=====================================
@@ -1907,8 +1907,8 @@ vlc_player_CorkCallback(vlc_object_t *this, const char *var,
 
     vlc_player_Unlock(player);
 
-    return VLC_SUCCESS;
     (void) this; (void) var;
+    return VLC_SUCCESS;
 }
 
 vlc_object_t *



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2b011c1f0d32dbc7604b0c953daaa349b9ee8c7b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2b011c1f0d32dbc7604b0c953daaa349b9ee8c7b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance