[vlc-commits] [Git][videolan/vlc][master] 2 commits: cdda: fix leaking musicbrainz ID

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
63e8fb6c by Steve Lhomme at 2025-09-25T08:34:59+00:00
cdda: fix leaking musicbrainz ID

- - - - -
dcb70aab by Steve Lhomme at 2025-09-25T08:34:59+00:00
cdda: remove always false test

We only get in the loop if str is not NULL as we want all artists to match.

- - - - -


1 changed file:

- modules/access/cdda.c


Changes:

=====================================
modules/access/cdda.c
=====================================
@@ -489,6 +489,7 @@ static musicbrainz_recording_t * GetMusicbrainzInfo( vlc_object_t *obj,
     if( psz_disc_id )
     {
         recording = musicbrainz_lookup_recording_by_discid( &cfg, psz_disc_id );
+        free( psz_disc_id );
     }
     else /* Fuzzy lookup using TOC */
     {
@@ -674,9 +675,6 @@ static void AccessGetMeta(stream_t *access, vlc_meta_t *meta)
                 const char *track_artist = cddb_track_get_artist(t);
                 if (NONEMPTY(track_artist))
                 {
-                    if (str == NULL)
-                        str = track_artist;
-                    else
                     if (strcmp(str, track_artist))
                     {
                         str = NULL;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/916b3aa23e265fa3bf87fed83c015ffce3e3d4c2...dcb70aab0d775526eec2e91131fa8f22aaeaf95b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/916b3aa23e265fa3bf87fed83c015ffce3e3d4c2...dcb70aab0d775526eec2e91131fa8f22aaeaf95b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance