[vlc-commits] [Git][videolan/vlc][master] qml: get rid of obsolete horizontal mode scroll buttons in `ListViewExt`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
cec6d1fa by Fatih Uzunoglu at 2026-04-04T03:17:36+00:00
qml: get rid of obsolete horizontal mode scroll buttons in `ListViewExt`

Currently there is no use case for this since a08c1491, and
we do not plan to introduce in the near future.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/ListViewExt.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/ListViewExt.qml
=====================================
@@ -30,9 +30,6 @@ ListView {
 
     // Properties
 
-    // NOTE: We want buttons to be centered vertically but configurable.
-    property int buttonMargin: height / 2 - buttonLeft.height / 2
-
     property ListSelectionModel selectionModel: ListSelectionModel {
         model: root.model
     }
@@ -61,11 +58,6 @@ ListView {
 
     property alias autoScrollDirection: viewDragAutoScrollHandlerLoader.scrollingDirection
 
-    //forward view properties
-
-    property alias buttonLeft: buttonLeft
-    property alias buttonRight: buttonRight
-
     // Signals
     signal actionAtIndex(int index)
 
@@ -741,43 +733,4 @@ ListView {
     }
 
     property Item dropIndicatorItem
-
-    // FIXME: We probably need to upgrade these RoundButton(s) eventually. And we probably need
-    //        to have some kind of animation when switching pages.
-
-    RoundButtonExt {
-        id: buttonLeft
-
-        anchors.left: parent.left
-        anchors.top: parent.top
-
-        anchors.topMargin: buttonMargin
-
-        text: '<'
-
-        visible: (root.orientation === ListView.Horizontal && !(root.atXBeginning))
-
-        onClicked: {
-            root.animatePage(root.prevPage)
-        }
-
-        activeFocusOnTab: false
-    }
-
-    RoundButtonExt {
-        id: buttonRight
-
-        anchors.right: parent.right
-        anchors.top: buttonLeft.top
-
-        text: '>'
-
-        visible: (root.orientation === ListView.Horizontal && !(root.atXEnd))
-
-        onClicked: {
-            root.animatePage(root.nextPage)
-        }
-
-        activeFocusOnTab: false
-    }
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cec6d1fadd7ced82bcd30f6bf3522abad5386a81

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cec6d1fadd7ced82bcd30f6bf3522abad5386a81
You're receiving this email because of your account on code.videolan.org.