[vlc-commits] [Git][videolan/vlc][master] 3 commits: qt: video details no longer show up in the grid view

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
e3edef51 by Atul Singh at 2026-04-08T01:38:00+00:00
qt: video details no longer show up in the grid view

Fixes #29689

Enable the info expand panel for videos by changing isInfoExpandPanelAvailable()
to return true in VideoGridDisplay.qml. This matches the behavior already
implemented in the Music Album view.

When selecting 'Information' from the context menu, the element would get
highlighted but the expand panel would not show up. This was because the
function returned false, preventing the panel from displaying.

- - - - -
51d16eb1 by Atul Singh at 2026-04-08T01:38:00+00:00
qt: fix video grid info panel expand delegate wiring

Fixes #29689

Declare the index and 
iew properties in VideoInfoExpandPanel so
ExpandGridView can assign them when opening the info panel.

Without these properties, runtime assignment can fail and the panel does
not open even when the Information action is triggered.

- - - - -
e7962cf7 by Atul Singh at 2026-04-08T01:38:00+00:00
qt: guard video info panel focus on context action

Fixes #29689

Guard the focus handoff in onShowMediaInformation to avoid trying
to focus a not-yet-instantiated expand item.

Also rely on ExpandGridView to provide expand item model/index/view
bindings, keeping the video grid delegate aligned with the shared
expand-view behavior.

- - - - -


2 changed files:

- modules/gui/qt/medialibrary/qml/VideoGridDisplay.qml
- modules/gui/qt/medialibrary/qml/VideoInfoExpandPanel.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/VideoGridDisplay.qml
=====================================
@@ -52,7 +52,7 @@ Widgets.ExpandGridItemView {
 
     // reimplement function to show "Info Panel" in grid view for the model index data
     function isInfoExpandPanelAvailable(modelIndexData) {
-        return false
+        return true
     }
 
     // Events
@@ -75,7 +75,7 @@ Widgets.ExpandGridItemView {
         function onShowMediaInformation(index) {
             gridView.switchExpandItem(index)
 
-            if (gridView.focus)
+            if (gridView.focus && expandItem)
                 expandItem.setCurrentItemFocus(Qt.TabFocusReason)
         }
     }
@@ -139,8 +139,6 @@ Widgets.ExpandGridItemView {
 
         width: gridView.width
 
-        model: gridView.model
-
         Navigation.parentItem: gridView
 
         Navigation.cancelAction: gridView.forceFocus


=====================================
modules/gui/qt/medialibrary/qml/VideoInfoExpandPanel.qml
=====================================
@@ -32,6 +32,8 @@ FocusScope {
     id: root
 
     property var model : ({})
+    property int index: -1
+    property Item view // can not use `ItemView` because of `ExpandGridView`
     property bool _showMoreInfo: false
     signal retract()
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/15d16ca68f7916927f6c25fddfdcd9c26cfb66e0...e7962cf7710c50a11dd349617d42e528fcbf7581

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/15d16ca68f7916927f6c25fddfdcd9c26cfb66e0...e7962cf7710c50a11dd349617d42e528fcbf7581
You're receiving this email because of your account on code.videolan.org.