[vlc-commits] [Git][videolan/vlc][master] mediacodec: add missing vlc_video_context_Hold()

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
1f0535c9 by Thomas Guillem at 2026-04-10T09:21:48+00:00
mediacodec: add missing vlc_video_context_Hold()

This call was missing in the new AImageReader path. This fixes a
possible UAF after a picture is cloned/copied.

PictureDestroyContext release unconditionally the video context, even if our
ctx->destroy implementation use a refcount.

Regression from 0aadefe758b10697b6c0b2515ac94be9186cd1f7

- - - - -


1 changed file:

- modules/codec/omxil/mediacodec.c


Changes:

=====================================
modules/codec/omxil/mediacodec.c
=====================================
@@ -852,6 +852,7 @@ android_picture_ctx_copy(picture_context_t *src)
 {
     struct android_picture_ctx *src_ctx = container_of(src, struct android_picture_ctx, s);
     vlc_atomic_rc_inc(&src_ctx->rc);
+    vlc_video_context_Hold(src_ctx->s.vctx);
     return &src_ctx->s;
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1f0535c97f4f0224505abf202c578292055111d5

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1f0535c97f4f0224505abf202c578292055111d5
You're receiving this email because of your account on code.videolan.org.