[vlc-commits] [Git][videolan/vlc][master] 2 commits: lib: fix wrong iteration bound in libvlc_media_tracklist_from_player

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
fe8febbe by Martin Finkel at 2026-04-11T01:55:47+00:00
lib: fix wrong iteration bound in libvlc_media_tracklist_from_player

- - - - -
6cb24ebe by Martin Finkel at 2026-04-11T01:55:47+00:00
lib: init count to 0 in libvlc_media_tracklist_from_player

- - - - -


1 changed file:

- lib/media_track.c


Changes:

=====================================
lib/media_track.c
=====================================
@@ -264,12 +264,13 @@ libvlc_media_tracklist_from_player( vlc_player_t *player,
 {
     const enum es_format_category_e cat = libvlc_track_type_to_escat( type );
 
-    size_t count = vlc_player_GetTrackCount( player, cat );
+    const size_t total_count = vlc_player_GetTrackCount( player, cat );
+    size_t count = 0;
 
     if( selected )
     {
         size_t selected_count = 0;
-        for( size_t i = 0; i < count; ++i )
+        for( size_t i = 0; i < total_count; ++i )
         {
             const struct vlc_player_track *track =
                 vlc_player_GetTrackAt( player, cat, i );
@@ -279,13 +280,15 @@ libvlc_media_tracklist_from_player( vlc_player_t *player,
         }
         count = selected_count;
     }
+    else
+        count = total_count;
 
     libvlc_media_tracklist_t *list = libvlc_media_tracklist_alloc( count );
 
     if( count == 0 || list == NULL )
         return list;
 
-    for( size_t i = 0; i < count; ++i )
+    for( size_t i = 0; i < total_count; ++i )
     {
         const struct vlc_player_track *track =
             vlc_player_GetTrackAt( player, cat, i );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a29072fa19d650ff35dbd8029271624670a41d1e...6cb24ebef79fb307e1b40e3887b0fd90586fdedb

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a29072fa19d650ff35dbd8029271624670a41d1e...6cb24ebef79fb307e1b40e3887b0fd90586fdedb
You're receiving this email because of your account on code.videolan.org.